Ensure Persistent Mount for /ark/backup Folder

[ntrehout]

Subject: Enhancement Request - Ensure Persistent Mount for /ark/backup Folder

---

Issue Description

Problem

I encountered a map corruption, and unfortunately, the restoration process failed due to the absence of the /ark/backup folder, which was not mounted. The pod restart resulted in the loss of the backup, exacerbating the situation.

Request

I propose enhancing the current setup to ensure the persistent mounting of the /ark/backup folder. This improvement would prevent the loss of backups during pod restarts and contribute to a more robust and reliable system.

Steps to Reproduce

1. Trigger a map corruption.
2. Attempt to restore from backup.
3. Observe the failure due to the /ark/backup folder not being mounted.

Expected Behavior

The /ark/backup folder should be consistently mounted, ensuring that backups persist across pod restarts and preventing data loss in the event of a map corruption.

Impact

Implementing this enhancement would positively impact the system's reliability by safeguarding backups and improving the recovery process in the face of unexpected events.

Thank you for considering this enhancement request. Feel free to reach out if further clarification or details are needed.

[DrPsychick]

I think the simplest way to achieve this, without adjusting the chart, would be to set arkbackupdir of ark-server-tools (https://github.com/arkmanager/ark-server-tools/blob/master/tools/arkmanager.cfg), which is set to /ark/backup by default in the base image: https://github.com/SickHub/arkserver/blob/8bd05b1c45c1892d51b047e1352ad528ab5c1721/arkmanager/arkmanager.cfg#L18C1-L18C13
You could set the path to an existing PVC, e.g. to a subdirectory of Saved.

The base image support setting any kind of arkmanager.cfg through environment variables starting with am_: https://github.com/SickHub/arkserver/blob/8bd05b1c45c1892d51b047e1352ad528ab5c1721/run.sh#L79

That being said, I agree that there should be an option to additionally provide a PVC for the /ark/backup directory.