You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem here is that this requires external binaries (ffmpeg/ffprobe). It's certainly possible to add this, but would likely become problematic on Windows requiring additional workarounds. The advantage of this package is that it requires no external binaries at the cost of requiring implementations for extracting data to live within the codebase.
Unfortunately it is non-trivial to get the duration for all video formats (I tried). Some don't store it or require more complex calculations (looking at you, ogv). The specifications for each vary in documentation quality as well which makes supporting this rather expensive/intensive to build (imagine implementing parts of ffmpeg/ffprobe in JS in a lightweight way).
At some point I do want to spend more time on this plugin since the initial focus was to go wide instead of deep (also due to specification info being scattered everywhere which makes it a pain to find the right spec for some cases).
All that said I must admit it is yet another good suggestion. However, implementing this would require me to fully understand every file format leather currently supports. This is going to take some significant amount of time 😅
I will leave this open since I do intend to give it another try for sure. But if you're building anything right now I would recommend installing an additional package or replacing leather all together with something which uses ffmpeg/ffprobe utilities.
The
get-media-dimensions
package does this, and also supports MP3s and other audio files:https://github.com/noblesamurai/get-media-dimensions
It would be quite nice to have this property as well.
The text was updated successfully, but these errors were encountered: