diff --git a/code/game/machinery/computer/message.dm b/code/game/machinery/computer/message.dm index ffbeea88d257a..04f2f733c4eb9 100644 --- a/code/game/machinery/computer/message.dm +++ b/code/game/machinery/computer/message.dm @@ -303,14 +303,16 @@ name = "Monitor Decryption Key" var/obj/machinery/message_server/server = null -/obj/item/paper/monitorkey/New() +/obj/item/paper/monitorkey/Initialize() ..() - spawn(10) - if(message_servers) - for(var/obj/machinery/message_server/server in message_servers) - if(!isnull(server)) - if(!isnull(server.decryptkey)) - info = "

Daily Key Reset


The new message monitor key is '[server.decryptkey]'.
This key is only intended for personnel granted access to the messaging server. Keep it safe.
If necessary, change the password to a more secure one." - info_links = info - icon_state = "paper_words" - break + return INITIALIZE_HINT_LATELOAD + +/obj/item/paper/monitorkey/LateInitialize(mapload) + if(message_servers) + for(var/obj/machinery/message_server/server in message_servers) + if(!isnull(server)) + if(!isnull(server.decryptkey)) + info = "

Daily Key Reset


The new message monitor key is '[server.decryptkey]'.
This key is only intended for personnel granted access to the messaging server. Keep it safe.
If necessary, change the password to a more secure one." + info_links = info + icon_state = "paper_words" + break diff --git a/code/game/objects/items/weapons/cards_ids.dm b/code/game/objects/items/weapons/cards_ids.dm index 2862b1f50a63c..b83789e9770a3 100644 --- a/code/game/objects/items/weapons/cards_ids.dm +++ b/code/game/objects/items/weapons/cards_ids.dm @@ -301,12 +301,7 @@ var/global/const/NO_EMAG_ACT = -50 id_card.formal_name_suffix = "[id_card.formal_name_suffix][culture.get_formal_name_suffix()]" id_card.registered_name = real_name - - var/pronouns = "Unset" - var/datum/pronouns/P = choose_from_pronouns() - if(P) - pronouns = P.formal_term - id_card.sex = pronouns + id_card.sex = get_formal_pronouns() id_card.set_id_photo(src) if(dna) diff --git a/code/modules/mob/mob.dm b/code/modules/mob/mob.dm index dfc0f452b63c1..d1e9f58072ca6 100644 --- a/code/modules/mob/mob.dm +++ b/code/modules/mob/mob.dm @@ -650,6 +650,13 @@ return P +/mob/proc/get_formal_pronouns() + var/datum/pronouns/P = GLOB.pronouns_from_gender[gender] + if (pronouns) + P = GLOB.pronouns.by_key[pronouns] + return P.formal_term + + /mob/proc/see(message) if(!is_active()) return 0 diff --git a/code/modules/modular_computers/file_system/reports/crew_record.dm b/code/modules/modular_computers/file_system/reports/crew_record.dm index 5a97f4463334d..60faad5304c93 100644 --- a/code/modules/modular_computers/file_system/reports/crew_record.dm +++ b/code/modules/modular_computers/file_system/reports/crew_record.dm @@ -49,12 +49,7 @@ GLOBAL_VAR_INIT(arrest_security_status, "Arrest") set_name(H ? H.real_name : "Unset") set_formal_name(formal_name) set_job(H ? GetAssignment(H) : "Unset") - var/pronouns = "Unset" - if(H) - var/datum/pronouns/P = H.choose_from_pronouns() - if(P) - pronouns = P.formal_term - set_sex(pronouns) + set_sex(H ? H.get_formal_pronouns() : "Unset") set_age(H ? H.age : 30) set_status(GLOB.default_physical_status) set_species(H ? H.get_species() : SPECIES_HUMAN) diff --git a/code/modules/species/station/nabber.dm b/code/modules/species/station/nabber.dm index 8dadb919ba88b..71452e927df18 100644 --- a/code/modules/species/station/nabber.dm +++ b/code/modules/species/station/nabber.dm @@ -287,11 +287,7 @@ var/image/threat_image = skin_overlays[image_key] if(!threat_image) - var/icon/base_icon = icon(H.stand_icon) - var/icon/I = new('icons/mob/human_races/species/nabber/threat.dmi', "threat") - base_icon.Blend(COLOR_BLACK, ICON_MULTIPLY) - base_icon.Blend(I, ICON_ADD) - threat_image = image(base_icon) + threat_image = image('icons/mob/human_races/species/nabber/threat.dmi', "threat") skin_overlays[image_key] = threat_image return(threat_image) diff --git a/icons/mob/human_races/species/nabber/threat.dmi b/icons/mob/human_races/species/nabber/threat.dmi index bf405c35247dd..6526439fbc928 100644 Binary files a/icons/mob/human_races/species/nabber/threat.dmi and b/icons/mob/human_races/species/nabber/threat.dmi differ diff --git a/test/check-paths.sh b/test/check-paths.sh index 8b1065c6784b6..0b4a815068968 100755 --- a/test/check-paths.sh +++ b/test/check-paths.sh @@ -48,7 +48,7 @@ exactly 24 "text2path uses" 'text2path' exactly 4 "update_icon() override" '/update_icon\((.*)\)' -P exactly 4 "goto use" 'goto ' exactly 1 "NOOP match" 'NOOP' -exactly 339 "spawn uses" '^\s*spawn\s*\(\s*(-\s*)?\d*\s*\)' -P +exactly 338 "spawn uses" '^\s*spawn\s*\(\s*(-\s*)?\d*\s*\)' -P exactly 0 "tag uses" '\stag = ' -P '**/*.dmm' exactly 0 "anchored = 0/1" 'anchored\s*=\s*\d' -P exactly 2 "density = 0/1" 'density\s*=\s*\d' -P