fix(k8s-infra): use agent container root for hostmetrics in GKE autopilot

[prashant-shahi]

Summary

Hostmetrics collection for GKE Autopilot is broken since we are unable to mount the root path / to the container path /hostfs.

Hence, for GKE Autopilot, we are reverting to the previous behaviour.

Fixes

• use agent container root for autopilot

Summary by CodeRabbit

• New Features

  • Enhanced configuration flexibility for the OpenTelemetry Collector, allowing for conditional application of settings based on user-defined values.
  • Added support for various preset configurations such as logs collection and resource detection.
  • Improved handling of host metrics configuration based on the cloud environment.

• Bug Fixes

  • Ensured that only relevant configurations are applied by unsetting pipelines with empty receivers or exporters.

[srikanthccv]

This is not a correct fix. We should figure out what to mount otherwise it produces undesired results.

[coderabbitai]

Walkthrough

The changes in this pull request focus on enhancing the configuration templates for the OpenTelemetry Collector, specifically the otelAgent and otelDeployment. New conditional logic has been introduced to manage configurations based on the presence of specific values in the .Values object. This includes checks for various presets that determine which configurations to apply, improving the flexibility and granularity of the setup.

Changes

File Path

Change Summary

charts/k8s-infra/templates/_config.tpl

- Updated otelAgent.config to include conditions for logsCollection, hostMetrics, kubeletMetrics, kubernetesAttributes, and resourceDetection. - Updated otelDeployment.config to add conditions for resourceDetection, clusterMetrics, and k8sEvents. - Modified hostMetricsConfig to include a condition for root_path based on the global cloud value. - Enhanced logic to unset pipelines if their receivers or exporters are empty.

Possibly related PRs

• fix(k8s-infra): enable k8sattributes to match other information #488: Modifies the _config.tpl file to add a new detector configuration for Kubernetes nodes.
• fix(k8s-infra): cleanup resource attribute for all signals #504: Updates the _config.tpl, specifically otelAgent.config and otelDeployment.config, aligning with the conditional logic changes.
• Ignore noisy host metrics data points #516: Enhances the hostMetricsConfig in _config.tpl, relevant to the main PR modifications.
• Update kubelet metrics collection #521: Updates the kubeletMetricsConfig in _config.tpl, related to the main PR changes.
• Enable few optional metrics for cluster metrics #522: Introduces new metrics configuration in _config.tpl, relevant to handling metrics and logs.
• Add k8sevents receiver #523: Adds new configuration options for handling Kubernetes events in _config.tpl, relating to enhancements in the main PR.

Suggested reviewers

• srikanthccv
• grandwizard28

🐰 In the meadow, where bunnies play,
Configs are changing, hip-hip-hooray!
With logic so clever, they adapt with ease,
OpenTelemetry flows like a gentle breeze.
From logs to metrics, all in a row,
Our setups are ready, let the data flow! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 65de46a and b9d473c.

📒 Files selected for processing (1)

• charts/k8s-infra/templates/_config.tpl (1 hunks)

🧰 Additional context used

🔇 Additional comments (1)

charts/k8s-infra/templates/_config.tpl (1)

202-204: Conditional 'root_path' setting accommodates GKE Autopilot limitations

The addition of the conditional statement ensures that root_path: /hostfs is set only when the environment is not gcp/autogke. This change appropriately addresses the issue where mounting the root path is unsupported in GKE Autopilot environments, thereby restoring hostmetrics collection functionality without affecting other environments.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.