GH-36: Send 0xFF by default for endpoint_find controllable with a flag #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with a flag A new flag have been introduced to send the endpoint Generic/Specific class in multi_channel_endpoint_find. The default behavior is to send 0xFF to discover all endpoints. Forwarded: SiliconLabs#36 Bug-SiliconLabs: UIC-3160 Bug-Github: SiliconLabs#36
|
After updating this fix to 1.5.0 SDK we are getting the generic and specific type from the ZPC. |
|
LGTM I will test it until approve Feel free to also pick this change to trigger tests: |
|
So let's make sure UIC-3160 is part of our next release (track git describe here) Cc: @silabs-borisl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new flag have been introduced to send the endpoint Generic/Specific class in multi_channel_endpoint_find to support legacy device.
This should fix the regression introduced with Unify 1.5 : The default behavior is to send 0xFF to discover all endpoints.
Forwarded: #37
Bug-SiliconLabs: UIC-3160
Bug-Github: #37