Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-UP] 917ncp init failure fix #133

Open
wants to merge 6 commits into
base: release_2.5-1.4
Choose a base branch
from

Conversation

arun-silabs
Copy link
Contributor

This PR fixes the init failure in 917NCP boards.
After integrating the matter_sdk code with the sl_net APIs, the init is failing because LWIP init is called twice for 917NCP.
To resolve this, we have removed the LWIP init from PlatformManager and modified the init sequence to avoid errors while booting. But, with the recent SPI related changes, we are facing SPI_BUSY error. So, reverted the recent changes made in efx32_ncp_host.c file. With these changes, the init for 917NCP is passing.

@arun-silabs arun-silabs requested a review from a team as a code owner November 26, 2024 16:36
@arun-silabs arun-silabs changed the title 917ncp init failure fix [SL-UP] 917ncp init failure fix Nov 26, 2024
@mkardous-silabs
Copy link
Contributor

Why does the efx32_ncp_host update cause errors? Did we root cause the the seen errors?

@arun-silabs
Copy link
Contributor Author

Why does the efx32_ncp_host update cause errors? Did we root cause the the seen errors?

The error is seen during SPI transfer, sl_si91x_host_spi_transfer() - This API is throwing SPI_BUSY error. I've tried to debug, but couldn't root cause it.
The SPI issue with the latest efx32_ncp_host.c file from wifi_sdk is coming up after integrating with sl_net layer. Need to debug the exact rootcause.

@mkardous-silabs
Copy link
Contributor

Why does the efx32_ncp_host update cause errors? Did we root cause the the seen errors?

The error is seen during SPI transfer, sl_si91x_host_spi_transfer() - This API is throwing SPI_BUSY error. I've tried to debug, but couldn't root cause it. The SPI issue with the latest efx32_ncp_host.c file from wifi_sdk is coming up after integrating with sl_net layer. Need to debug the exact rootcause.

Let me know when we have a better idea with what is happening with the latest efx32 ncp host file and the sl_net APIs. It might be worth while to open a Wiseconnect issue for this to get them involved.

@mkardous-silabs mkardous-silabs added the sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release. label Nov 27, 2024
@bhmanda-silabs
Copy link
Contributor

Why does the efx32_ncp_host update cause errors? Did we root cause the the seen errors?

The error is seen during SPI transfer, sl_si91x_host_spi_transfer() - This API is throwing SPI_BUSY error. I've tried to debug, but couldn't root cause it. The SPI issue with the latest efx32_ncp_host.c file from wifi_sdk is coming up after integrating with sl_net layer. Need to debug the exact rootcause.

Let me know when we have a better idea with what is happening with the latest efx32 ncp host file and the sl_net APIs. It might be worth while to open a Wiseconnect issue for this to get them involved.

Wiseconnect ticket - https://jira.silabs.com/browse/WIFISDK-1109

#define LDMA_MAX_TRANSFER_LENGTH 4096
#define LDMA_DESCRIPTOR_ARRAY_LENGTH (LDMA_MAX_TRANSFER_LENGTH / 2048)

// use SPI handle for EXP header (configured in project settings)
extern SPIDRV_Handle_t sl_spidrv_exp_handle;
#define SPI_HANDLE sl_spidrv_exp_handle
static uint8_t dummy_buffer[MAX_DATA_PACKET_SIZE] = { 0 };
static uint8_t dummy_buffer[1800] = { 0 };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
static uint8_t dummy_buffer[1800] = { 0 };
static uint8_t dummy_buffer[MAX_DATA_PACKET_SIZE] = { 0 };

#include "sl_spidrv_exp_config.h"
#include "sl_spidrv_instances.h"
#include "spidrv.h"

#define MAX_DATA_PACKET_SIZE 1800
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep this define for clarify?

Comment on lines 43 to 44
#include "sl_si91x_ncp_utility.h"
#include <platform/silabs/wifi/wf200/platform/spi_multiplex.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't need to be seperate - can we keep them with the rest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants