diff --git a/7.2/alpine3.6/cli/Dockerfile b/7.2/alpine3.6/cli/Dockerfile index 353f648f8..4a0e86f8b 100644 --- a/7.2/alpine3.6/cli/Dockerfile +++ b/7.2/alpine3.6/cli/Dockerfile @@ -122,7 +122,7 @@ RUN set -xe \ # --enable-mysqlnd is included here because it's harder to compile after the fact than extensions are (since it's a plugin for several extensions, not an extension in itself) --enable-mysqlnd \ # https://wiki.php.net/rfc/libsodium - --with-sodium \ + --with-sodium=shared \ \ --with-curl \ --with-libedit \ @@ -157,6 +157,9 @@ RUN set -xe \ COPY docker-php-ext-* docker-php-entrypoint /usr/local/bin/ +# sodium was built as a shared module (so that it can be replaced later if so desired), so let's enable it too (https://github.com/docker-library/php/issues/598) +RUN docker-php-ext-enable sodium + ENTRYPOINT ["docker-php-entrypoint"] #### CMD ["php", "-a"] diff --git a/7.2/alpine3.6/fpm/Dockerfile b/7.2/alpine3.6/fpm/Dockerfile index 37d9d2275..08f1fb6e7 100644 --- a/7.2/alpine3.6/fpm/Dockerfile +++ b/7.2/alpine3.6/fpm/Dockerfile @@ -123,7 +123,7 @@ RUN set -xe \ # --enable-mysqlnd is included here because it's harder to compile after the fact than extensions are (since it's a plugin for several extensions, not an extension in itself) --enable-mysqlnd \ # https://wiki.php.net/rfc/libsodium - --with-sodium \ + --with-sodium=shared \ \ --with-curl \ --with-libedit \ @@ -158,6 +158,9 @@ RUN set -xe \ COPY docker-php-ext-* docker-php-entrypoint /usr/local/bin/ +# sodium was built as a shared module (so that it can be replaced later if so desired), so let's enable it too (https://github.com/docker-library/php/issues/598) +RUN docker-php-ext-enable sodium + ENTRYPOINT ["docker-php-entrypoint"] #### WORKDIR /var/www/html diff --git a/7.2/alpine3.6/zts/Dockerfile b/7.2/alpine3.6/zts/Dockerfile index 60ba1e309..e615b8a0f 100644 --- a/7.2/alpine3.6/zts/Dockerfile +++ b/7.2/alpine3.6/zts/Dockerfile @@ -123,7 +123,7 @@ RUN set -xe \ # --enable-mysqlnd is included here because it's harder to compile after the fact than extensions are (since it's a plugin for several extensions, not an extension in itself) --enable-mysqlnd \ # https://wiki.php.net/rfc/libsodium - --with-sodium \ + --with-sodium=shared \ \ --with-curl \ --with-libedit \ @@ -158,6 +158,9 @@ RUN set -xe \ COPY docker-php-ext-* docker-php-entrypoint /usr/local/bin/ +# sodium was built as a shared module (so that it can be replaced later if so desired), so let's enable it too (https://github.com/docker-library/php/issues/598) +RUN docker-php-ext-enable sodium + ENTRYPOINT ["docker-php-entrypoint"] #### CMD ["php", "-a"] diff --git a/7.2/alpine3.7/cli/Dockerfile b/7.2/alpine3.7/cli/Dockerfile index 9cf33d9db..539184dcd 100644 --- a/7.2/alpine3.7/cli/Dockerfile +++ b/7.2/alpine3.7/cli/Dockerfile @@ -122,7 +122,7 @@ RUN set -xe \ # --enable-mysqlnd is included here because it's harder to compile after the fact than extensions are (since it's a plugin for several extensions, not an extension in itself) --enable-mysqlnd \ # https://wiki.php.net/rfc/libsodium - --with-sodium \ + --with-sodium=shared \ \ --with-curl \ --with-libedit \ @@ -157,6 +157,9 @@ RUN set -xe \ COPY docker-php-ext-* docker-php-entrypoint /usr/local/bin/ +# sodium was built as a shared module (so that it can be replaced later if so desired), so let's enable it too (https://github.com/docker-library/php/issues/598) +RUN docker-php-ext-enable sodium + ENTRYPOINT ["docker-php-entrypoint"] #### CMD ["php", "-a"] diff --git a/7.2/alpine3.7/fpm/Dockerfile b/7.2/alpine3.7/fpm/Dockerfile index 7766e4d54..85f03fe22 100644 --- a/7.2/alpine3.7/fpm/Dockerfile +++ b/7.2/alpine3.7/fpm/Dockerfile @@ -123,7 +123,7 @@ RUN set -xe \ # --enable-mysqlnd is included here because it's harder to compile after the fact than extensions are (since it's a plugin for several extensions, not an extension in itself) --enable-mysqlnd \ # https://wiki.php.net/rfc/libsodium - --with-sodium \ + --with-sodium=shared \ \ --with-curl \ --with-libedit \ @@ -158,6 +158,9 @@ RUN set -xe \ COPY docker-php-ext-* docker-php-entrypoint /usr/local/bin/ +# sodium was built as a shared module (so that it can be replaced later if so desired), so let's enable it too (https://github.com/docker-library/php/issues/598) +RUN docker-php-ext-enable sodium + ENTRYPOINT ["docker-php-entrypoint"] #### WORKDIR /var/www/html diff --git a/7.2/alpine3.7/zts/Dockerfile b/7.2/alpine3.7/zts/Dockerfile index 320ba333b..8eb3cf7c7 100644 --- a/7.2/alpine3.7/zts/Dockerfile +++ b/7.2/alpine3.7/zts/Dockerfile @@ -123,7 +123,7 @@ RUN set -xe \ # --enable-mysqlnd is included here because it's harder to compile after the fact than extensions are (since it's a plugin for several extensions, not an extension in itself) --enable-mysqlnd \ # https://wiki.php.net/rfc/libsodium - --with-sodium \ + --with-sodium=shared \ \ --with-curl \ --with-libedit \ @@ -158,6 +158,9 @@ RUN set -xe \ COPY docker-php-ext-* docker-php-entrypoint /usr/local/bin/ +# sodium was built as a shared module (so that it can be replaced later if so desired), so let's enable it too (https://github.com/docker-library/php/issues/598) +RUN docker-php-ext-enable sodium + ENTRYPOINT ["docker-php-entrypoint"] #### CMD ["php", "-a"] diff --git a/7.2/stretch/apache/Dockerfile b/7.2/stretch/apache/Dockerfile index 231173f17..4c00e3c95 100644 --- a/7.2/stretch/apache/Dockerfile +++ b/7.2/stretch/apache/Dockerfile @@ -204,7 +204,7 @@ RUN set -eux; \ # https://wiki.php.net/rfc/argon2_password_hash (7.2+) --with-password-argon2 \ # https://wiki.php.net/rfc/libsodium - --with-sodium \ + --with-sodium=shared \ \ --with-curl \ --with-libedit \ @@ -246,6 +246,9 @@ RUN set -eux; \ COPY docker-php-ext-* docker-php-entrypoint /usr/local/bin/ +# sodium was built as a shared module (so that it can be replaced later if so desired), so let's enable it too (https://github.com/docker-library/php/issues/598) +RUN docker-php-ext-enable sodium + ENTRYPOINT ["docker-php-entrypoint"] #### COPY apache2-foreground /usr/local/bin/ diff --git a/7.2/stretch/cli/Dockerfile b/7.2/stretch/cli/Dockerfile index c3542ec94..0a70f0e2d 100644 --- a/7.2/stretch/cli/Dockerfile +++ b/7.2/stretch/cli/Dockerfile @@ -145,7 +145,7 @@ RUN set -eux; \ # https://wiki.php.net/rfc/argon2_password_hash (7.2+) --with-password-argon2 \ # https://wiki.php.net/rfc/libsodium - --with-sodium \ + --with-sodium=shared \ \ --with-curl \ --with-libedit \ @@ -187,6 +187,9 @@ RUN set -eux; \ COPY docker-php-ext-* docker-php-entrypoint /usr/local/bin/ +# sodium was built as a shared module (so that it can be replaced later if so desired), so let's enable it too (https://github.com/docker-library/php/issues/598) +RUN docker-php-ext-enable sodium + ENTRYPOINT ["docker-php-entrypoint"] #### CMD ["php", "-a"] diff --git a/7.2/stretch/fpm/Dockerfile b/7.2/stretch/fpm/Dockerfile index 5e8e5e2ce..7d5569ff3 100644 --- a/7.2/stretch/fpm/Dockerfile +++ b/7.2/stretch/fpm/Dockerfile @@ -146,7 +146,7 @@ RUN set -eux; \ # https://wiki.php.net/rfc/argon2_password_hash (7.2+) --with-password-argon2 \ # https://wiki.php.net/rfc/libsodium - --with-sodium \ + --with-sodium=shared \ \ --with-curl \ --with-libedit \ @@ -188,6 +188,9 @@ RUN set -eux; \ COPY docker-php-ext-* docker-php-entrypoint /usr/local/bin/ +# sodium was built as a shared module (so that it can be replaced later if so desired), so let's enable it too (https://github.com/docker-library/php/issues/598) +RUN docker-php-ext-enable sodium + ENTRYPOINT ["docker-php-entrypoint"] #### WORKDIR /var/www/html diff --git a/7.2/stretch/zts/Dockerfile b/7.2/stretch/zts/Dockerfile index fa397c2e9..cf733dfc4 100644 --- a/7.2/stretch/zts/Dockerfile +++ b/7.2/stretch/zts/Dockerfile @@ -146,7 +146,7 @@ RUN set -eux; \ # https://wiki.php.net/rfc/argon2_password_hash (7.2+) --with-password-argon2 \ # https://wiki.php.net/rfc/libsodium - --with-sodium \ + --with-sodium=shared \ \ --with-curl \ --with-libedit \ @@ -188,6 +188,9 @@ RUN set -eux; \ COPY docker-php-ext-* docker-php-entrypoint /usr/local/bin/ +# sodium was built as a shared module (so that it can be replaced later if so desired), so let's enable it too (https://github.com/docker-library/php/issues/598) +RUN docker-php-ext-enable sodium + ENTRYPOINT ["docker-php-entrypoint"] #### CMD ["php", "-a"] diff --git a/Dockerfile-alpine.template b/Dockerfile-alpine.template index 08c469144..c3c259af8 100644 --- a/Dockerfile-alpine.template +++ b/Dockerfile-alpine.template @@ -116,7 +116,7 @@ RUN set -xe \ # --enable-mysqlnd is included here because it's harder to compile after the fact than extensions are (since it's a plugin for several extensions, not an extension in itself) --enable-mysqlnd \ # https://wiki.php.net/rfc/libsodium - --with-sodium \ + --with-sodium=shared \ \ --with-curl \ --with-libedit \ @@ -151,6 +151,9 @@ RUN set -xe \ COPY docker-php-ext-* docker-php-entrypoint /usr/local/bin/ +# sodium was built as a shared module (so that it can be replaced later if so desired), so let's enable it too (https://github.com/docker-library/php/issues/598) +RUN docker-php-ext-enable sodium + ENTRYPOINT ["docker-php-entrypoint"] #### CMD ["php", "-a"] diff --git a/Dockerfile-debian.template b/Dockerfile-debian.template index ba9a61e12..feed90256 100644 --- a/Dockerfile-debian.template +++ b/Dockerfile-debian.template @@ -139,7 +139,7 @@ RUN set -eux; \ # https://wiki.php.net/rfc/argon2_password_hash (7.2+) --with-password-argon2 \ # https://wiki.php.net/rfc/libsodium - --with-sodium \ + --with-sodium=shared \ \ --with-curl \ --with-libedit \ @@ -181,6 +181,9 @@ RUN set -eux; \ COPY docker-php-ext-* docker-php-entrypoint /usr/local/bin/ +# sodium was built as a shared module (so that it can be replaced later if so desired), so let's enable it too (https://github.com/docker-library/php/issues/598) +RUN docker-php-ext-enable sodium + ENTRYPOINT ["docker-php-entrypoint"] #### CMD ["php", "-a"] diff --git a/update.sh b/update.sh index a9617cca4..343901ade 100755 --- a/update.sh +++ b/update.sh @@ -166,6 +166,14 @@ for version in "${versions[@]}"; do sed -ri '/sodium/d' "$version/$suite/$variant/Dockerfile" fi + # remove any _extra_ blank lines created by the deletions above + awk ' + NF > 0 { blank = 0 } + NF == 0 { ++blank } + blank < 2 { print } + ' "$version/$suite/$variant/Dockerfile" > "$version/$suite/$variant/Dockerfile.new" + mv "$version/$suite/$variant/Dockerfile.new" "$version/$suite/$variant/Dockerfile" + # automatic `-slim` for stretch # TODO always add slim once jessie is removed sed -ri \