-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error handling #32
Comments
Mainly the zbus backend needs better error handling now, this will come with v0.8 |
I have noticed that the following place is still using unwraps, which could be a problem when souvlaki/src/platform/mpris/zbus.rs Lines 97 to 98 in e6ff34b
The Error trace from our side (0.7.3)This Error trace is what got me to investigate it, and it should still be somewhat relevant in 0.8.0 regarding [2024-12-09T22:59:43.712+01:00 ERROR termusic_server::logger]: Panic occured:
panicked at /home/sigurd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/souvlaki-0.7.3/src/platform/mpris/zbus.rs:100:22:
called `Result::unwrap()` on an `Err` value: NameTaken
disabled backtrace
thread '<unnamed>' panicked at /home/sigurd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/souvlaki-0.7.3/src/platform/mpris/zbus.rs:100:22:
called `Result::unwrap()` on an `Err` value: NameTaken
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[2024-12-09T22:59:43.811+01:00 ERROR termusic_server::logger]: Panic occured:
panicked at /home/sigurd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/souvlaki-0.7.3/src/platform/mpris/zbus.rs:139:29:
called `Result::unwrap()` on an `Err` value: SendError { .. }
disabled backtrace
thread 'main player loop' panicked at /home/sigurd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/souvlaki-0.7.3/src/platform/mpris/zbus.rs:139:29:
called `Result::unwrap()` on an `Err` value: SendError { .. }
[2024-12-09T22:59:43.811+01:00 ERROR termusic_server::logger]: Panic occured:
panicked at /home/sigurd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/souvlaki-0.7.3/src/platform/mpris/zbus.rs:112:53:
called `Result::unwrap()` on an `Err` value: SendError { .. }
disabled backtrace
thread 'main player loop' panicked at /home/sigurd/.cargo/registry/src/index.crates.io-6f17d22bba15001f/souvlaki-0.7.3/src/platform/mpris/zbus.rs:112:53:
called `Result::unwrap()` on an `Err` value: SendError { .. } |
unwrap
is used a lot throughout the code at this moment. And the platform errors don't implementstd::error::Error
. Both seem to be easy fixes.The text was updated successfully, but these errors were encountered: