-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.3 update thread (WIP) #7
Comments
Body and depth filtering work.
Depth filtering is a lot more unreliable than with Kinect v2 though. |
A lot of progress! I'm a bit disappointed in V1 RGB quality but I knew the resolution was low. The background removal is impressive though.
Oh, that would drastically improve general webcam usability, hope you can get that to work. I'm too lazy to build this myself but if you post a beta build I can try both Kinects this week. |
I though it was going to be worse than that but yeah, it's outputting a 480p color image (opposed to the 1080p of the v2). Kinect v1 does support 1280x960 color images at 15 FPS, I'll add support for this as well.
I think I'll be able to do that on v2 by using a library made by Microsoft (found here), unfortunately it's not open-source and is only compiled for x64, which means I won't be able to do that on the 32bits version of this plugin (shouldn't be a big deal though, I think almost everyone uses a 64bits OS now).
I will! 0.3 is really a big update and will require a lot of testing before being out. You can expect a release candidate release in the next few days! |
I feel stupid. I managed to halve frametime by... not processing the same image twice. Fixed in aac42ca |
First release candidate for v0.3 is out! |
I just tried this addon with Kinect V1 360 and It perfectly maps me out of the picture and leaves the background, I can't seem to reverse it so the background is removed. |
Haha, first Time I hear that. |
Oh right, the Kinect for 360 cannot read depth below 80cm in front of it (up to 400cm), Kinect for Windows can bring this range to 40-200cm by enabling "near mode". Kinect v2 (xbox one) has a range of about 50-500cm. There's nothing I can do against this, as it's an hardware limitation. |
Nah I get it! It was just my own stupidity, It works really well! Props to u my dude 👍 |
Hello guys. It's been a few days since 0.3 RC2 got out and I fixed some minor stuff already for RC3/0.3 release. Did you encounter some bugs/crashes I could fix before releasing 0.3? Please tell me, I don't want to have to release a 0.3.1. 😄 Also, there's one or two keys missing in the german translation, could someone take a look at that? |
I only tried V2 for a few minutes. No bugs or crashes. The main thing I noticed is my green screen error is actually pretty consistent, in my case shifted to the left. If I could nudge the cutout by X percent or pixel that looks like it would dial it in pretty well. |
That's weird. Could you show me what it looks like? |
I'm using a V1 Xbox 360 version and camera options like auto-exposure, brightness, exposure time, frame interval and gain doesn't change anything. Camera elevation does work correctly. |
Did you try to disable auto-exposure and play with the other options? I fixed a bug recently which prevented device-specific settings to be applied at device acquisition (when the source shows up, when OBS is started, etc.). |
Yes, I've tried it with different combinations. |
Okay so you have a Kinect for 360, maybe that's the same issue as #13 and changing camera parameters is not supported on that model. Could you try to use Microsoft Developer Toolkit Browser and run the Kinect Explorer example? It has some options to controls those settings. If that doesn't work I guess I can't do much. I wonder if libfreenect is able to do this. Edit: Oh I forgot to ask, do you have errors in OBS log? |
No errors in the logs. I've checked Kinect Explorer and the only options are related to resolution or picture type (rgb, yuv, infrared, rawbayer), no mention of brightness or such. |
RTX 2060 |
Maybe try updating your drivers, I'm having a RTX 2080 Ti and no issue. The logs seem to be pointing a driver crash. It would be easier if I could reproduce any of theses crash myself. |
I´m on 460.79. Should be quite recent. Wanted to update/look up for the newest driver but I can´t complete the form on the nvidia page. Tried three different browsers... guess nvidia doesn´t like me |
Updated to last 460.89 WHQL by downloading it from third party site. Still same issue. Works when I first open the settings and crashes then when changing the background mode several times. Not a big issue maybe. I can work around. Great update btw! ;) |
Thanks! All I need to do now before releasing this as the 1.0 version is to make it work with Linux using libfreenect. Shouldn't be that complex 😄 |
One more note: Removed all old Kinect sources. Added a new one. Changed background effect -> crash. |
Unticking the checkbox to use gpu to compute color-to-depth-calculation leads to some weird background removal. The cut area stays the same as before and not adapting to movement anymore. (Wanted to try to let the cpu do the workload as my gpu is not the strongest) (Kinectservice.exe uses up to 14% and obs up to 12% gpu load according to task manager. Without streaming. Quite heavy load in my oppinion.) |
I'll take a look at that, thanks for letting me know |
@SirLynix congrats on the great work! After testing the build you posted above I spotted the folllowing issues:
Crash 2020-12-27 23-44-34.txt |
Hi, thank you for reporting this!
It still looks like a driver crash, this is very strange. I tried to reproduce this issue without success, I'll try with another computer soon.
I would love to be able to expose this, as the other Kinect models work this way too, but the Kinectv2 expects red, green and blue gains. If I had a way to convert from Kelvin to RGB I'd do it (maybe you know a way?).
That's why it's called "unknown" 😄. It's a valid white balance mode (as it's accepted by the Kinect) but doesn't seem to do anything different from manual without red/green/blue gains conf.
Did you try the latest version? (obs-kinect-locales.zip)
I'm not sure I can do anything about that to be honest, but I'll try! |
@SirLynix it turned out I was not on the latest version. Everything seems to work now. Even the crashes are gone. I was wrong about 50/60hz mode. I tested with another light and it does make a difference when changing the setting. Regarding conversion of color temperature to RGB gains it seems this is what is needed. I tried putting it in a spreadsheet but my calculation seems to be wrong somewhere. |
huge difference with the newest update. it's much better at not cutting out stuff it isn't supposed to. for whatever reason it didn't work on 50hz mode (kinect v2) and i'm wondering if you wouldn't want to default this to 60hz. |
So you mean you had to change the powerline frequency to have an output? What was happening before that? Did something shows up in obs logs ? |
actually I think I got regular video output using 50hz, but trying to use
the green screen effect produced no output until I switched it to 60hz.
didn't check the logs, not super familiar with that but if you want me to
check something I can!
…On Tue, Jan 19, 2021, 2:00 AM Jérôme Leclercq ***@***.***> wrote:
So you mean you had to change the powerline frequency to have an output?
What was happening before that?
Did something shows up in obs logs ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKOQBAJMREHKL7LA5YQ4STS2U33NANCNFSM4MXBEOIA>
.
|
How can I build the latest version? Are there instructions somewhere? EDIT: never mind just saw it in the readme |
Yes, the readme has a "How to build" section. But it requires a lot of dependencies (at least one per kinect model + obs-studio source code). |
@SirLynix I'm not sure if i make any sense at all |
I'm not sure to understand. Near mode is already enabled by default for xbox 360 (I think I still have to make a checkbox for that). Which brings the minimal readable depth to ~40cm in front of the Kinect, which means the minimum distance won't have any effect as long as its value is below 400mm. |
isn't this type of near mode only usable on kinect for windows v1 and kinect v2? |
Near mode is something that only works with Kinect v1 (360 and kinect for Windows v1), I'm not aware of Kinect v2 having that feature. |
I've managed to setup nightlies builds for Windows and Linux. Nightlies builds are the most up-to-date builds of obs-kinect, with every feature I'm working on (and every bug I've yet to fix too!). Select the most up-to-date (at the top) build that succeeded and download the "releasedbg" artifacts. About 1.0 (and stable version): I've got to work on the libfreenect backend (for Kinect v1 on Linux) and finish the libfreenect2 backend (it only needs minor stuff like camera controls and such). |
Hi, I wanna package it for arch linux, but I'm not sure exactly where should i place the files |
Hi. In the archive you'll find a data/obs-plugins folder, I suppose it's one of the folder you're talking about. The other obs-plugins folder contains some of the plugins binaries, the other binaries should lie next to the obs-studio executable. |
so "/obs-plugins/64bit/" files should also go to "/usr/bin/" "/data/obs-plugins/obs-kinect/" files should go to "/usr/share/obs/obs-plugins/obs-kinect/" correct? |
Except for plugin binary files i'd say yes. There's probably a obs-plugins folder somewhere, can't say where to find it (maybe try looking where other OBS plugins install?) |
Yes it seems it's at the right place. However the reason it's not working is because obs-kinect doesn't support Kinect v1 on Linux at the moment, it's on my todo list and should be quick to add but I have a ton of works on other projects. Will try to do it soon! |
Some update about the next obs-kinect version!
General stuff
I massively refactored the code, and improved performance. You can now have multiples Kinect v2 sources at the cost of one (Kinect images/color to depth mapping will only be done once instead of once per source, dramatically improving performance). I'm not sure if that's gonna be helpful but still, it's an improvement.
I also added body and depth hybrids (as requested by someone on reddit):
One of the big stuff about the refactor is also the support for multiple Kinects from multiple frameworks!
This is done by having all code related to a Kinect runtime (or even all Windows specific stuff) in a separate .dll which is loaded by obs-kinect at startup. This was made to add support for freenect(2) in the future, making the plugin available on Linux and macOS (won't be in the 0.3).
There's also a new "Kinect service priority" combo box, which tells obs-kinect to raise the priority of the KinectService.exe process, this is helpful in case where your CPU is under heavy load (like compiling/playing games) and prevents/reduce lost images. (this is only an issue with Kinect runtime 2.0, afaik all other frameworks, including Kinect runtime v1.0 and freenect, don't have a separate service for this).
Also:
About Kinect v1
As you can see, I'm now able to retrieve Kinect v1 color and depth streams. I'm even able to retrieve both of them at the same time (which isn't as straightforward than with Kinect v2) and try to do some green-screen stuff.
... Okay that part still needs some work.
Interesting notes about Kinect v1:
That last one was a surprise for me, it also works quite well (even better than my own background removal with Kinect v2, except for the color quality).
Here's an example from Microsoft SDK:
I wish to be able to have something this smooth for Kinect v2 one day.
Anyway, I'll expose this new source for Kinect v1 (unfortunately v2 doesn't have that).
I have no idea when 0.3 will be out, things complicated a lot because of all the Kinect v1 possibilities (and because it's working in such a different way from Kinect v2). I'll update this thread if I have anything relevant to say about this.
I'm sometimes streaming obs-kinect dev on Twitch
I worked on obs-kinect 0.3 body/depth hybrids in english some days ago, you can see the replay here:
https://www.twitch.tv/videos/605065358
I also worked on the Kinect v1 support, in my native language (french) here:
https://www.twitch.tv/videos/607021382
Enjoy!
The text was updated successfully, but these errors were encountered: