Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMetadata does not support monorepo #2037

Open
ahiyalala opened this issue Feb 7, 2025 · 1 comment
Open

getMetadata does not support monorepo #2037

ahiyalala opened this issue Feb 7, 2025 · 1 comment
Labels
backlog Issue/PR/discussion is reviewed and added to backlog for the further work 🐞 bug

Comments

@ahiyalala
Copy link

Describe the Bug

For monorepo projects that uses turborepo for example, getMetadata does not allow for retrieving the whole list of sitecore dependencies due to the line:

queryResult = JSON.parse(execSync('npm query [name*=@sitecore] **--workspaces false**').toString())

This either left metadata.json empty {} or only contains an incomplete set of packages.

To Reproduce

Run npm run start:connected on a monorepo-based project

Expected Behavior

metadata.json should contain the list of required packages

Possible Fix

Remove --workspaces false parameter in the getMetadata npm command

Provide environment information

  • Sitecore Version: XM Cloud
  • JSS Version: 22.1
  • Browser Name and version: Edge
  • Operating System and version (desktop or mobile): Windows 11
  • Link to your project (if available): N/A
@yavorsk
Copy link
Contributor

yavorsk commented Feb 11, 2025

Thanks for the submission, I am adding an item in our backlog to work on fixing this.

@yavorsk yavorsk added the backlog Issue/PR/discussion is reviewed and added to backlog for the further work label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issue/PR/discussion is reviewed and added to backlog for the further work 🐞 bug
Projects
None yet
Development

No branches or pull requests

2 participants