Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beam beam special case to be handled #114

Open
giadarol opened this issue Dec 9, 2019 · 2 comments
Open

Beam beam special case to be handled #114

giadarol opened this issue Dec 9, 2019 · 2 comments
Labels
Milestone

Comments

@giadarol
Copy link
Contributor

giadarol commented Dec 9, 2019

Found in pysixtrack tests that beam beam has a division by zero if:

  • beam is round
  • particle is exactly in the origin

Fixed in pysixtrack, implement also in Sixtracklib

@martinschwinzerl
Copy link
Contributor

@giadarol : would it be acceptable to use

(x*x + y*y) < ( min_sigma_diff * min_sigma_diff)

instead of

(fabs(x) + fabs(y)) < min_sigma_diff

This would be easier to vectorize and we can reuse the x*x + y*y term multiple times in the same function. Plus, if I understand correctly, this is condition gauges the "real" (euclidian) distance from the reference particle rather than the maximum norm

@giadarol
Copy link
Contributor Author

That’s perfectly fine

@martinschwinzerl martinschwinzerl added this to the v0.7.0 milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants