-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sourcery refactored master branch #1
base: master
Are you sure you want to change the base?
Conversation
|
if not repo["identifier"] in vcs: | ||
if repo["identifier"] not in vcs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function get_all_workspaces
refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan
)
for version in AVAILABLE_TERRAFORM_VERSIONS: | ||
if version in check: | ||
return True | ||
return False | ||
return any(version in check for version in AVAILABLE_TERRAFORM_VERSIONS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function validate_terraform_version
refactored with the following changes:
- Use any() instead of for loop (
use-any
)
if i == "Y": | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function main
refactored with the following changes:
- Simplify conditional into switch-like form (
switch
) - Remove redundant conditional (
remove-redundant-if
)
Sourcery Code Quality Report (beta)✅ Merging this PR will increase code quality in the affected files by 0.07 out of 10.
Here are some functions in these files that still need a tune-up:
Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! |
Branch
master
refactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
master
branch, then run: