Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcery refactored master branch #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Jul 16, 2020

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

@height
Copy link

height bot commented Jul 16, 2020

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

if not repo["identifier"] in vcs:
if repo["identifier"] not in vcs:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function get_all_workspaces refactored with the following changes:

  • Simplify logical expression using De Morgan identities (de-morgan)

for version in AVAILABLE_TERRAFORM_VERSIONS:
if version in check:
return True
return False
return any(version in check for version in AVAILABLE_TERRAFORM_VERSIONS)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function validate_terraform_version refactored with the following changes:

  • Use any() instead of for loop (use-any)

Comment on lines -256 to +253
if i == "Y":
else:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function main refactored with the following changes:

  • Simplify conditional into switch-like form (switch)
  • Remove redundant conditional (remove-redundant-if)

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Jul 16, 2020

Sourcery Code Quality Report (beta)

✅ Merging this PR will increase code quality in the affected files by 0.07 out of 10.

Before After Change
Quality 7.26 7.33 0.07
Complexity 9.14 8.57 -0.57
Method Length 108.39 107.25 -1.14
Lines 255 252 -3
Changed files Quality Before Quality After Quality Change
src/main.py 7.26 7.33 0.07 ⬆️

Here are some functions in these files that still need a tune-up:

File Function Quality Recommendation
src/main.py get_all_workspaces 1.95 Reduce complexity. Split out functionality
src/main.py main 4.56 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants