Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support restart #91

Open
1 of 3 tasks
zhenik opened this issue Jun 16, 2021 · 0 comments
Open
1 of 3 tasks

Support restart #91

zhenik opened this issue Jun 16, 2021 · 0 comments

Comments

@zhenik
Copy link
Contributor

zhenik commented Jun 16, 2021

Feature description

terraform-nomad-hive on startup phase, schemaTool binary runs, which attempts to create/upgrade tables in postgres DB.

https://github.com/Skatteetaten/terraform-nomad-hive/blob/master/docker/bin/hivemetastore#L4-L5

When nomad restart, hive restart also. terraform-nomad-hive accidentally fail on startup phase when restarts.

Why is it needed?

We need support redeploys, restart.

Suggestion(s)/solution(s) [Optional]

I see there is attempt to support restart(s) with || true at the end of cmd. But it is not seem enough to handle restarts.

hive --service schemaTool -initSchema -dbType postgres --verbose || true 
hive --service schemaTool -upgradeSchema -dbType postgres --verbose || true

Definition of done

terraform-nomad-hive restarts correctly

Checklist (after created issue)

  • Added label(s)
  • Added to project
  • Added to milestone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant