Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use catch_unwind to protect the worker thread #1

Open
Skepfyr opened this issue Feb 13, 2021 · 1 comment
Open

Use catch_unwind to protect the worker thread #1

Skepfyr opened this issue Feb 13, 2021 · 1 comment

Comments

@Skepfyr
Copy link
Owner

Skepfyr commented Feb 13, 2021

Requiring that the user's closures are UnwindSafe feels reasonable, and this would massively decrease the risk that someone could bork all DiplomaticBags.
@Skepfyr
Copy link
Owner Author

Skepfyr commented Feb 13, 2021

The more I think about it the less convinced I am that we actually need UnwindSafe here as the panic is going to get propagated to the original thread, however I'm not entirely sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Skepfyr