Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload referencing missing icon #196

Open
Eneroth3 opened this issue Oct 6, 2021 · 1 comment
Open

Reload referencing missing icon #196

Eneroth3 opened this issue Oct 6, 2021 · 1 comment

Comments

@Eneroth3
Copy link

Eneroth3 commented Oct 6, 2021

The reload command references a "arrow_refresh.png" icon. This file however appears to be missing.

It seems these lines adding the icon could just be removed, as this command is primarily added to a menu (only added to toolbar if extension is in debug mode). An image file could also be added.

@thomthom
Copy link
Member

Ah, this is a debug command.

testup-2/src/testup/ui.rb

Lines 105 to 116 in e3891c9

cmd = Command.new('Reload TestUp') {
TESTUP_CONSOLE.clear
window_visible = @window && @window.visible?
@window.close if window_visible
@window = TestUpWindow.new
@window.show if window_visible
puts "Reloaded #{self.reload} files!"
}
cmd.tooltip = 'Reload TestUp'
cmd.small_icon = File.join(PATH_IMAGES, 'arrow_refresh.png')
cmd.large_icon = File.join(PATH_IMAGES, 'arrow_refresh.png')
cmd_reload_testup = cmd

It's always added to the Debug menu:

sub_menu.add_item(cmd_reload_testup)

And conditionally added to the toolbar:

testup-2/src/testup/ui.rb

Lines 189 to 192 in e3891c9

if TestUp::DEBUG
toolbar.add_separator
toolbar.add_item(cmd_reload_testup)
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants