-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for LogLevel in EffLog #6659
Conversation
Added wats to declare severity when logging
Updated `@Since` to include when severity to logs was added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have more probably just for now here's this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More changes near you. Let's update the #toString(Event e, boolean debug)
while we're here, to include severity tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, have you actually tested this? I'd like to see a screenshot of the output.
adding breaking changes due to adding INFO to the output by default. |
I have not |
Sorry but how does this apply a breaking change? Very confused there. |
alright so let's do an actual test equip
this should log on reload my guess is severe will not work but info and warning will |
This is why I was talking about a RedirectingLogHandler in discord |
…nto dev/feature
changes to use .toString instead of String.valueOf
Description
Added ways to declare severity when logging
Target Minecraft Versions: any
Requirements: none
Related Issues: none