🚀 Add Cancellable section #5691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyhamAl-Ali
added
feature
TheLimeGlass
approved these changes
May 10, 2023
APickledWalrus
approved these changes
May 12, 2023
APickledWalrus
requested changes
May 12, 2023
Moderocky
force-pushed
the
master
branch
2 times, most recently
from
bd134d0
to
3f08853
Compare
sovdeeth
approved these changes
Dec 30, 2023
sovdeeth
added
2.9
APickledWalrus
approved these changes
Apr 9, 2024
| @@ -603,6 +609,17 @@ private String generateEvent(String descTemp, SkriptEventInfo<?> info, @Nullable | |||
| String[] keywords = info.getKeywords(); | |||
| desc = desc.replace("${element.keywords}", keywords == null ? "" : Joiner.on(", ").join(keywords)); | |||
|
|
|||
| // Cancellable | |||
| boolean cancellable = false; | |||
| for (Class<? extends Event> event : info.events) { | |||
There was a problem hiding this comment.
I wonder if it might be good to have a common isCancellable method between this and EffCancelEvent
Moderocky
approved these changes
Apr 26, 2024
Moderocky
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🚀 Add Cancellable section
Preview
nvm about testing values
Target Minecraft Versions:
Requirements:
Related Issues: