Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions being delayed doesn't properly error #79

Closed
1 task done
TheLimeGlass opened this issue Dec 27, 2023 · 4 comments
Closed
1 task done

Functions being delayed doesn't properly error #79

TheLimeGlass opened this issue Dec 27, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@TheLimeGlass
Copy link

TheLimeGlass commented Dec 27, 2023

Skript/Server Version

2.8.0-dev
Paper 1.20.1

Bug Description

The error at https://github.com/SkriptLang/Skript/blob/1a009cdb1419292046de0e95429bcb40eaaaab15/src/main/java/ch/njol/skript/effects/EffReturn.java#L73 is not properly erroring when a delay is added into a function. Instead Skript is erroring stating that the return effect cannot be used in a function, when this is indeed incorrect.

Expected Behavior

To properly print the error stating delays cannot be used in functions.

Steps to Reproduce

function testing(empty: boolean = false) :: boolean:
	wait a second
	return true

Errors or Screenshots

2023-12-27_12 35 59

Other

Return API SkriptLang/Skript#6118 which is not on this Skript jar.

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@Fusezion
Copy link

Fusezion commented Dec 27, 2023

This isn't skript issue this is reflect, put over there. they have their own system and overrides skript's

@TheLimeGlass
Copy link
Author

#78

@TheLimeGlass
Copy link
Author

Actually keeping this open for an admin to transfer this issue.

@sovdeeth sovdeeth transferred this issue from SkriptLang/Skript Dec 29, 2023
@sovdeeth sovdeeth added the bug Something isn't working label Jan 2, 2024
@Pikachu920
Copy link
Member

Due to the new return API being utilized, EffReturn no longer exists so this is not applicable anymore. Thank you regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants