Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player List API (Interface with the tab list) #32

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Player List API (Interface with the tab list) #32

wants to merge 5 commits into from
+276 −0

Conversation

Ascynx
Copy link
Member

@Ascynx Ascynx commented Jun 30, 2023 •
edited
Loading

Currently planned:

  • Access to tab list data, main list, header, footer.
  • Access to footer data per category e.g: Active Effects, Cookie Buff, Upgrades.
  • Access to tab list data depending on the category e.g: Players, Server Info, Account Info.

@Ascynx Ascynx added the enhancement New feature or request label Jun 30, 2023
@Ascynx
Categorized player list data
c5fc293 
Works fine for Header and footer but still a few hiccups to deal with with the main tab list.
@Ascynx
Categorized tab data.
eb3143f 
Fixed tab categories being overriden if they appeared twice.

Also refactored getTabCategories -> getPlayerListCategories.
@Ascynx Ascynx marked this pull request as ready for review July 2, 2023 10:37
@Zickles
Copy link
Contributor

Zickles commented Jul 30, 2023

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ascynx @Zickles