Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all links #102

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Fix all links #102

merged 3 commits into from
Oct 12, 2023

Conversation

kurtmckee
Copy link
Contributor

While reviewing the CONTRIBUTING doc, I noticed that it rendered poorly.

image

While addressing this, I also noticed that many links in the project use HTTP, resulting in a redirect for a protocol upgrade. I introduced a separate commit to replace all of the HTTP links with HTTPS.

The CONTRIBUTING doc now renders like this:

image

Copy link
Contributor

@sledigabel sledigabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixing all the links in the comments/docs.
Thanks for your contribution @kurtmckee !

Copy link
Collaborator

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too - thanks @kurtmckee

@rnorth rnorth merged commit 35beb17 into Skyscanner:main Oct 12, 2023
5 checks passed
@kurtmckee kurtmckee deleted the fix-all-links branch October 12, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants