Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed angle_compensate_nodes array overflow issue #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed angle_compensate_nodes array overflow issue #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ int main(int argc, char * argv[]) {
//const int angle_compensate_multiple = 1;
const int angle_compensate_nodes_count = 360*angle_compensate_multiple;
int angle_compensate_offset = 0;
rplidar_response_measurement_node_hq_t angle_compensate_nodes[angle_compensate_nodes_count];
rplidar_response_measurement_node_hq_t angle_compensate_nodes[angle_compensate_nodes_count+8];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hardcode 8 ? I would understand 1 to add one more time the size of a rplidar_response_measurement_node_hq_t to the size of the memory space, but 8 ? This is not a pointer, and even if it was, this an array on the stack, not a malloc-ed buffer, so the size is not counted the same by the language.

If 1 is not the correct option I don't know what is, but 8 is for sure not the right thing to write. The function being huge it is hard to tell what is what but there must be a variable or a formula that makes sense.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 is not the right thing to write. Because I already spent a lot time, I hate this but that's a solution at least.

Note: I have used Google's AddressSanitizer to detect the corruption. Valgrind or gdb didn't work for me.

memset(angle_compensate_nodes, 0, angle_compensate_nodes_count*sizeof(rplidar_response_measurement_node_hq_t));

int i = 0, j = 0;
Expand Down