Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeLib defines DAYS_PER_WEEK as type time_t with a value of 7. TimeL… #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TimeLib defines DAYS_PER_WEEK as type time_t with a value of 7. TimeL… #153

wants to merge 1 commit into from

Commits on Sep 15, 2021

  1. TimeLib defines DAYS_PER_WEEK as type time_t with a value of 7. TimeL… 

    …ib's time_t is defined as unsigned long with a value of 7. This is compatable with NeoGPS declaration of DAYS_PER_WEEK with type uint8_t if cast to uint8_t. I modified the code to check if DAYS_PER_WEEK is defined and cast DAYS_PER_WEEK as uint8_t when used.

This is an alternate way to resolve the conflict between NeoGPS and TimeLib. User, tscofield, proposed a similar fix by renaming DAYS_PER_WEEK but I believe this may be a slightly better resolution to the issue.

See issues

- [https://github.com/SlashDevin/NeoGPS/pull/115](https://github.com/SlashDevin/NeoGPS/pull/115 "NeoGPS Issue 115")
- [https://github.com/PaulStoffregen/Time/issues/163](https://github.com/PaulStoffregen/Time/issues/163 "TimeLib Issue 163")

BTW: I looked into applying a similar fix to TimeLib but the issue only seemed to be resolved when applied to NeoGPS.
    @richteel
    richteel committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    9490bf3 View commit details
    Browse the repository at this point in the history