Merge pull request #611 from SlateFoundation/develop

Release: v3.4.3
SlateFoundation · Oct 12, 2021 · 6049182 · 6049182
2 parents 4195d95 + eab9346
commit 6049182
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/.holo/sources/slate.toml b/.holo/sources/slate.toml
@@ -1,3 +1,3 @@
 [holosource]
 url = "https://github.com/SlateFoundation/slate"
-ref = "refs/tags/v2.16.3"
+ref = "refs/tags/v2.16.5"
diff --git a/data-exporters/slate-cbl/student-tasks.php b/data-exporters/slate-cbl/student-tasks.php
@@ -274,13 +274,13 @@
             foreach ($StudentTask->Task->Attachments as $Attachment) {
                 $attachments[] = $Attachment->URL;
             }
-            $teacherAttachments = !empty($attachments) ? '"'.implode('", "', $attachments).'"' : null;
+            $teacherAttachments = !empty($attachments) ? implode(',', $attachments) : null;
 
             $attachments = [];
             foreach ($StudentTask->Attachments as $Attachment) {
                 $attachments[] = $Attachment->URL;
             }
-            $studentAttachments = !empty($attachments) ? '"'.implode('", "', $attachments).'"' : null;
+            $studentAttachments = !empty($attachments) ? implode(',', $attachments) : null;
 
             yield [
                 'StudentTaskID' => $StudentTask->ID,

diff --git a/php-classes/Slate/CBL/Tasks/StudentTask.php b/php-classes/Slate/CBL/Tasks/StudentTask.php
@@ -174,8 +174,8 @@ public function getOrCreateDemonstration()
         if (!$this->Demonstration) {
             $this->Demonstration = ExperienceDemonstration::create([
                 'StudentID' => $this->StudentID,
-                'PerformanceType' => $this->Task->Title,
-                'Context' => $this->Task->Section->Title,
+                'PerformanceType' => $this->Task->getTitle(),
+                'Context' => $this->Task->Section->getTitle(),
                 'ExperienceType' => $this->Task->ExperienceType
             ]);
         }

diff --git a/php-migrations/Slate/CBL/Tasks/20161007000000_student-task-ratings.php b/php-migrations/Slate/CBL/Tasks/20161007000000_student-task-ratings.php
@@ -65,8 +65,8 @@
             'StudentID' => $StudentTask->StudentID,
             'Demonstrated' => $StudentTask->Submitted ?: null,
             'ExperienceType' => $StudentTask->ExperienceType,
-            'PerformanceType' => $StudentTask->Task->Title,
-            'Context' => $StudentTask->Section->Title
+            'PerformanceType' => $StudentTask->Task->getTitle(),
+            'Context' => $StudentTask->Section->getTitle()
         ]);
         $Demonstration->save(false);