ENH: Include system runtime libraries #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a termination fault when running the CLI executable when it was built with a newer MSVC relative to another computer with an older runtime. Including the runtime libraries will make sure compatibility is correct instead of falling back to the system version.
jamesobutler
force-pushed
the
system-library-dependency
branch
from
18e7d57
to
4d5c6ba
Compare
|
Slicer is already expected to package the needed runtime along the application. I will look at the referenced issue to better understand and see how to fix the root cause. |
|
(ignore what I wrote before - since this only comes up when launching a CLI and not when launching Slicer itself, the launcher itself should be fine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of addressing Slicer/Slicer#7847.
This avoids a termination fault when running the CLI executable when it was built with a newer MSVC relative to another computer with an older runtime. Including the runtime libraries will make sure compatibility is correct instead of falling back to the system version.