Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document purpose of installWMA.sh script #125

Open
jhlegarreta opened this issue Jul 3, 2023 · 1 comment
Open

Document purpose of installWMA.sh script #125

jhlegarreta opened this issue Jul 3, 2023 · 1 comment

Comments

@jhlegarreta
Copy link
Contributor

The purpose of the script
https://github.com/SlicerDMRI/whitematteranalysis/blob/6d93b6452b32ebedbee29674766abfe752dd1d04/slicer/installWMA.sh

is not documented anywhere. Is it useful/relevant so that WMA can effectively call Slicer modules?

Also, it contains hard-coded

  • The INSTALLFOLDER is certainly a hard-coded macOS path; if the script is relevant, can this be made flexible enough to be used at least for a Linux OS?
  • If the parent folder says slicer, there are no Slicer paths present in this script.
  • The WMAFOLDER can be an arbitrary, so not sure how Slicer can be aware of this path.

Happy to help/test.

@ljod
Copy link
Member

ljod commented Jul 3, 2023

I don't remember the history of this, but if it is unused I recommend removal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants