Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make atlas version being available, pointed and downloaded consistent #126

Open
jhlegarreta opened this issue Jul 5, 2023 · 2 comments
Open

Comments

@jhlegarreta
Copy link
Contributor

jhlegarreta commented Jul 5, 2023

The ORG atlases in the ORG-Atlases repository have received a few updates over time, e g.
SlicerDMRI/ORG-Atlases@fb19973

Also, the file history in Zenodo shows a few versions:
https://zenodo.org/search?page=1&size=20&q=conceptrecid:%222648283%22&sort=-version&all_versions=True

According to its README file, we can download the atlas files manually or automatically using WMA tools (i.e. this repository)

On the one hand, for some reason, the ZIP files (e.g. ORG-Tracts-MRB.zip, ORG-800FiberClusters.zip, ORG-800FC-100HCP.zip) pointed by the README do not correspond to the latest version of the atlas.

On the other hand, the version of the files that the WMA tool downloads is hard-coded:

And it does not correspond to the most recent version available.

Additionally, the documentation for the tractography parcellation step points to the 1.1.1 version of the atlas, e.g.:

- The O'Donnell Research Group (ORG) white matter atlas (“_ORG-Atlases-1.1.1_”)

Finally, the atlas bundle dictionary is hard-coded here:

hemispheric_tracts = ["T_AF", "T_CB", "T_CPC", "T_MdLF", "T_PLIC", "T_SLF-I", "T_SLF-II", "T_SLF-III", "T_EC", "T_EmC", "T_ICP", "T_ILF", "T_IOFF", "T_UF",

And it has not been updated to the changes in the commit pointed above.

So it is highly likely that the files downloaded manually or using the WMA tool become inconsistent, which may be a problem.

So the files being available, those pointed in the README, and those downloaded by the script should correspond exactly to the same versions to avoid problems.

@ljod
Copy link
Member

ljod commented Jul 6, 2023

Thanks for looking at this! Fan can you let us know what version we should all be using? @zhangfanmark

@jhlegarreta
Copy link
Contributor Author

PRs #132 and #133 address some of these points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants