Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor filter and laterality modules: joblib is not optional #227

Open
jhlegarreta opened this issue Jan 2, 2024 · 0 comments
Open

Refactor filter and laterality modules: joblib is not optional #227

jhlegarreta opened this issue Jan 2, 2024 · 0 comments

Comments

@jhlegarreta
Copy link
Contributor

The filter and laterality modules try to use joblib modules conditionally if importing it is successful:

joblib, have_joblib, _ = optional_package("joblib")

joblib, have_joblib, _ = optional_package("joblib")

However, joblib is a required dependency:,

so the if/else blocks in the above modules are not necessary, e.g. (there are multiple hits):

if have_joblib and n_jobs > 0:

if (have_joblib & (self.parallel_jobs > 1)):

Removing the conditional blocks may require some work, as the else blocks seem to contain a more complex/different logic with respect to the counterpart using the parallelization capabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant