Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to cleanup redundant and misplaced code in dblpconf, OPENRESEARCH migration, geograpy and wikirender #243

Open
WolfgangFahl opened this issue Jul 10, 2021 · 3 comments
Assignees
Milestone

Comments

@WolfgangFahl
Copy link
Collaborator

WolfgangFahl commented Jul 10, 2021

There should be a clean separation of concerns:

  • wikirender is responsible for handling modifications in wikimarkup files
  • OPENRESEARCH migration is responsible for handling the Event,EventSeries (EventCorpus) and Location handling
  • geograpy has the entities for Location,Country,Region and City and the potential candidates for those
  • dblpconf is a misnomer it is the webfrontend and as such only responsible for web related functionality and RESTFUL APIs the implementation of OPENRESEARCH related functionality is in OPENRESEARCH
@WolfgangFahl WolfgangFahl added this to the 2021-09 milestone Jul 10, 2021
@WolfgangFahl WolfgangFahl self-assigned this Jul 10, 2021
@WolfgangFahl
Copy link
Collaborator Author

WolfgangFahl commented Jul 10, 2021

The main functions of each fixer should work independently for better testability and a common command line api for each fixer.

All Fixers should have the pipe capabilty as specified a few weeks ago. The Code in wikirender's wikiExtract has tried to get this capability but it's not integrated with the WikiFilemanager and or the EventCorpus at this time.

During the fixer process the

  • entity as a python instance (Event, EventSeries,Location (Country,Region,City)
  • its corresponding wiki page (e.g. as a pageTitle and corresponding wiki)
  • it's corresponding wiki markup (WikiFile)
    need to be consistently available via well designed APIs. Currently the approach is much to adhoc and redundant and not well tested enough.

The source backuppath should be the standard wiki backup path for a given wiki id. The fixing staging area needs to be specified.

@WolfgangFahl
Copy link
Collaborator Author

@WolfgangFahl
Copy link
Collaborator Author

Almost done - close when Continuous Integration of https://github.com/WolfgangFahl/ConferenceCorpus and https://github.com/WolfgangFahl/ProceedingsTitleParser work again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant