Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GND-ID template parameter inconsistent for Event and EvenSeries #272

Open
tholzheim opened this issue Apr 7, 2022 · 1 comment
Open

GND-ID template parameter inconsistent for Event and EvenSeries #272

tholzheim opened this issue Apr 7, 2022 · 1 comment
Assignees
@WolfgangFahl @tholzheim
Labels
question

Comments

@tholzheim
Copy link
Collaborator

For events the GND-ID is set with gndId= and for event series the property is set with GND-ID= even though both parameters set the same property.

Should the parameter name be aligned so that for event and event series the GND-ID is set with the same template parameter name?

Current GND-ID distribution:

  • EventSeries: 83
  • Event: 454
@WolfgangFahl
Copy link
Collaborator

yes - please fix gndId or GndId is IMHO the camelcase version more closely to our standards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WolfgangFahl WolfgangFahl

@tholzheim tholzheim

Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WolfgangFahl @tholzheim