Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more than one MRender per host/port combo #12

Open
skaze opened this issue Mar 26, 2017 · 0 comments
Open

Support more than one MRender per host/port combo #12

skaze opened this issue Mar 26, 2017 · 0 comments

Comments

@skaze
Copy link

skaze commented Mar 26, 2017

Some systems, notably Logitech Squeezebox, uses a client-server model where each Squeezebox device (Radio, Touch, Soft, etc) is a type of thin client and all the functionality is provided through the server. Individual devices are identified by a parameter in the URL, rather than their specific IPs.

This is best reflected by the log messages from the MediaRender Connect SmartApp - here you can see 6 different MRenders found via UPNP however 5 have the same host/port (192.168.1.2:9000) (note i may have had to make changes to the code to get this output but it was hack and I think I've broken other assumptions in the code used to identify/index players from internal maps/lists):

f947bcaf-e0cf-407d-bb35-0f6fe87c49ba 13:26:15: trace verifyMediaRenderer(C0A80102:2328, /plugins/UPnP/MediaRenderer.xml?player=00%3A04%3A20%3A2a%3A97%3A65, 192.168.1.2:9000)
f947bcaf-e0cf-407d-bb35-0f6fe87c49ba 13:26:15: trace verifyMediaRenderer(C0A80102:2328, /plugins/UPnP/MediaRenderer.xml?player=00%3A04%3A20%3A26%3A55%3Ac9, 192.168.1.2:9000)
f947bcaf-e0cf-407d-bb35-0f6fe87c49ba 13:26:15: trace verifyMediaRenderer(C0A80102:2328, /plugins/UPnP/MediaRenderer.xml?player=01%3A79%3Aca%3Af7%3A57%3Ad1, 192.168.1.2:9000)
f947bcaf-e0cf-407d-bb35-0f6fe87c49ba 13:26:15: trace verifyMediaRenderer(C0A80102:2328, /plugins/UPnP/MediaRenderer.xml?player=00%3A04%3A20%3A29%3Ab0%3A3e, 192.168.1.2:9000)
f947bcaf-e0cf-407d-bb35-0f6fe87c49ba 13:26:15: trace verifyMediaRenderer(C0A80102:2328, /plugins/UPnP/MediaRenderer.xml?player=b8%3A27%3Aeb%3A51%3Af6%3Afa, 192.168.1.2:9000)
f947bcaf-e0cf-407d-bb35-0f6fe87c49ba 13:26:15: trace verifyMediaRenderer(C0A8011D:1F90, /description.xml, 192.168.1.29:8080)

The assumption made in the code that a player (MRender) is uniquely identified by a host and port is thus incorrect.

@skaze skaze changed the title MRender are not uniquely identified by host and port (more than one MRender per host) MRenders are not uniquely identified by host and port (more than one MRender per host) Mar 26, 2017
@skaze skaze changed the title MRenders are not uniquely identified by host and port (more than one MRender per host) Support more than one MRender per host/port combo Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant