Skip to content

Commit 0e837f9

Browse files
committed
Rename data-span-rows to data-span-cols.
1 parent 4b8d8e2 commit 0e837f9

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

templates/dashboard/%name%.erb.tt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="grid">
22
<div class="row">
3-
<div data-span-rows="4" data-id="my_widget" data-view="Text"></div>
3+
<div data-span-cols="4" data-id="my_widget" data-view="Text"></div>
44
</div>
55
</div>

templates/project/assets/stylesheets/application.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ h3 {
163163
flex: 1;
164164
}
165165

166-
.widget[data-span-rows="2"] {
166+
.widget[data-span-cols="2"] {
167167
min-width: 2 * $widget-width;
168168
padding-left: $widget-margin;
169169
padding-right: $widget-margin;

templates/project/dashboards/sample.erb

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
<div class="row">
44
<div data-id="welcome" data-view="Text" data-title="Hello" data-text="This is your shiny new dashboard." data-moreinfo="Protip: You can resize this window"></div>
55
<div data-id="synergy" data-view="Meter" data-title="Synergy" data-height="200" data-width="200" data-min="0" data-max="100" data-suffix="%"></div>
6-
<div data-span-rows="2" data-id="buzzwords" data-view="List" data-unordered="true" data-title="Buzzwords" data-moreinfo="# of times said around the office"></div>
6+
<div data-span-cols="2" data-id="buzzwords" data-view="List" data-unordered="true" data-title="Buzzwords" data-moreinfo="# of times said around the office"></div>
77
</div>
88
<div class="row">
9-
<div data-span-rows="2" data-id="valuation" data-view="Number" data-title="Current Valuation" data-moreinfo="In billions" data-prefix="$"></div>
10-
<div data-span-rows="2" data-id="convergence" data-view="Graph" data-title="Convergence" style="background-color:#ff9618"></div>
9+
<div data-span-cols="2" data-id="valuation" data-view="Number" data-title="Current Valuation" data-moreinfo="In billions" data-prefix="$"></div>
10+
<div data-span-cols="2" data-id="convergence" data-view="Graph" data-title="Convergence" style="background-color:#ff9618"></div>
1111
</div>
1212
<center><div style="font-size: 12px">Try this: curl -d '{ "auth_token": "YOUR_AUTH_TOKEN", "text": "Hey, Look what I can do!" }' \http://<%=request.host%>:<%=request.port%>/widgets/welcome</div></center>
1313
</div>

templates/project/dashboards/sampletv.erb

+4-4
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,17 @@ $(function() {
1313
<div class="row">
1414
<div data-view="Clock"></div>
1515
<div data-view="Image" data-image="/logo.png"></div>
16-
<div data-span-rows="2" data-id="welcome" data-view="Text" data-title="Hello" data-text="This is your shiny new 1080p dashboard." data-moreinfo="Protip: You can resize the window!"></div>
16+
<div data-span-cols="2" data-id="welcome" data-view="Text" data-title="Hello" data-text="This is your shiny new 1080p dashboard." data-moreinfo="Protip: You can resize the window!"></div>
1717
</div>
1818
<div class="row">
1919
<div data-id="synergy" data-view="Meter" data-title="Synergy" data-min="0" data-max="100"></div>
2020
<div data-id="synergy" data-view="Meter" data-moreinfo="In sync with my neighbour!" data-title="Synergy" data-min="0" data-max="100"></div>
21-
<div data-span-rows="2" data-id="buzzwords" data-view="List" data-unordered="true" data-title="Buzzwords" data-moreinfo="# of times said around the office"></div>
21+
<div data-span-cols="2" data-id="buzzwords" data-view="List" data-unordered="true" data-title="Buzzwords" data-moreinfo="# of times said around the office"></div>
2222
<div data-id="karma" data-view="Number" data-title="Karma" style="background-color:#96bf48;"></div>
2323
</div>
2424
<div class="row">
25-
<div data-span-rows="2" data-id="convergence" data-view="Graph" data-title="Convergence" style="background-color:#47bbb3;"></div>
26-
<div data-span-rows="2" data-id="twitter_mentions" data-view="Comments" style="background-color:#ff9618;" data-moreinfo="Tweets tagged with #todayilearned"></div>
25+
<div data-span-cols="2" data-id="convergence" data-view="Graph" data-title="Convergence" style="background-color:#47bbb3;"></div>
26+
<div data-span-cols="2" data-id="twitter_mentions" data-view="Comments" style="background-color:#ff9618;" data-moreinfo="Tweets tagged with #todayilearned"></div>
2727
<div data-id="karma" data-view="Number" data-title="Karma" data-moreinfo="In sync with my neighbour!" style="background-color:#96bf48;"></div>
2828
</div>
2929
<center><div style="font-size: 12px">Try this: curl -d '{ "auth_token": "YOUR_AUTH_TOKEN", "text": "Hey, Look what I can do!" }' \http://<%=request.host%>:<%=request.port%>/widgets/welcome</div></center>

0 commit comments

Comments
 (0)