Fix shop status in retailer's details #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync forked repo
Fix missing line from this commit : Smile-SA@06611a1
Since last versions of StoreLocator module (>=2.0.3), shopStatus value contains <span> child elements of .showopeninghours The preivous css rule (fixed in StoreLocator) was adding multiple icons (foreach span element)
|
I also added a fix for the same area : it removes multiple icons in shop-status by fixing ambiguous css rule Since last versions of StoreLocator module (>=2.0.3), shopStatus value contains child elements of .showopeninghours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix proposes to put back the line responsible for setting shopStatus observable value. Currently the shop status is displayed at "0" in store details (observable initialization value), and this value is never set.
For the record, this line was removed back then for incompatibilities with store-locator 2.0 module in our custom repo.