Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUPERNOVAS_VERSION_STRING ill defined in novas.h #24

Closed
attipaci opened this issue May 22, 2024 · 0 comments · Fixed by #25
Closed

SUPERNOVAS_VERSION_STRING ill defined in novas.h #24

attipaci opened this issue May 22, 2024 · 0 comments · Fixed by #25
Assignees
@attipaci
Labels
bug Something isn't working
Milestone
1.1.0

Comments

@attipaci
Copy link
Collaborator

The definition of SUPERNOVAS_VERSION_STRING in novas.h was entirely bunged in version <= 1.0.1. Will fix for the next release.
@attipaci attipaci added the bug Something isn't working label May 22, 2024
@attipaci attipaci added this to the Next bug fix release milestone May 22, 2024
@attipaci attipaci self-assigned this May 22, 2024
attipaci added a commit that referenced this issue May 22, 2024
@attipaci
Issue #24: Fix SUPERNOVAS_VERSION_STRING macro
0fda0cc
@attipaci attipaci mentioned this issue May 22, 2024
Merged
@attipaci attipaci pinned this issue May 22, 2024
attipaci added a commit that referenced this issue May 22, 2024
@attipaci
Build improvements (and fixes) to facilitate downstream packaging (#25)
a9ecdfb 
* Issue #24: Fix SUPERNOVAS_VERSION_STRING macro

* Issue #23: Build improvements with easier packaging in mind

* cio_file.c: Fix warnings about unchecked return values

* version.c: Build utility for printing version string

* make to use externally defined LDFLAGS also when generating .so files

* Smarter make shared and make static implementations
@attipaci attipaci linked a pull request May 27, 2024 that will close this issue
Build improvements (and fixes) to facilitate downstream packaging #25
Merged
@attipaci attipaci modified the milestones: 1.0.2, 1.1.0 Jun 29, 2024
@attipaci attipaci unpinned this issue Jun 29, 2024
@attipaci attipaci pinned this issue Jun 29, 2024
@attipaci attipaci unpinned this issue Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@attipaci attipaci

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Build improvements (and fixes) to facilitate downstream packaging Smithsonian/SuperNOVAS
1 participant
@attipaci