Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork resilience has been disabled since the new Meson build #37

Open
MrAnno opened this issue Jan 31, 2022 · 2 comments
Open

Fork resilience has been disabled since the new Meson build #37

MrAnno opened this issue Jan 31, 2022 · 2 comments

Comments

@MrAnno
Copy link
Collaborator

MrAnno commented Jan 31, 2022

Shouldn't we re-enable BXF_FORK_RESILIENCE by default?

@Snaipe
Copy link
Owner

Snaipe commented Feb 1, 2022

Leaving it off by default is probably the better default. Fork safety is very delicate and not guaranteed to work on all platforms & pthread implementations, and not all users might decide to use threads necessarily. Even when using threads, all forks are followed by exec() so we don't need to clean up the locks & threads in the children, at maybe the risk to see some deadlocks if there's a programming error in BoxFort.

In any case, this option has risks, and enabling it should come with full awareness of what this means.

@MrAnno
Copy link
Collaborator Author

MrAnno commented Feb 1, 2022

Oh, I see.
Thank you for the insight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants