-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rooms to share files even across different networks #89
Comments
There is another open source app that has this feature: |
It's great. How did you achieve it? I don't know much about node.js. |
@nover2 Have a look at https://github.com/RobinLinus/snapdrop/blob/894824eb19708c5950c9076b2c4f50b489b2d4f0/server/index.js#L60. There you'll see that Snapdrop groups users (peers) by their IP address. This is great to start. To achieve rooms across different networks you need to update the app and let the frontend/backend create valid unique room id's that are added to the URL so that the URL can be shared and users using the same URL are sharing the same room no matter in which network they are. |
@opusonline |
@nover2 |
@opusonline |
@nover2 |
@opusonline maybe you can make a PR out of your changes? This may help the developers merge in this feature faster. |
Duplicate of #144 |
This tool is awesome! Not only its code is fantastic, it even works without trackers and ads. Thank you for that!
One thing I miss sorely is to share files across different networks. I know that online tools are using rooms to achieve this.
So it would be a very nice addition to Snapdrop if it would allow to create a room where all members can even join from different networks.
I've already tested it and so I can say it is possible and would work nicely (See screenshot).
Do you have any concerns or do you agree?
The text was updated successfully, but these errors were encountered: