Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rooms to share files even across different networks #89

Closed
opusonline opened this issue Aug 15, 2019 · 9 comments
Closed

Rooms to share files even across different networks #89

opusonline opened this issue Aug 15, 2019 · 9 comments

Comments

@opusonline
Copy link

This tool is awesome! Not only its code is fantastic, it even works without trackers and ads. Thank you for that!

One thing I miss sorely is to share files across different networks. I know that online tools are using rooms to achieve this.

So it would be a very nice addition to Snapdrop if it would allow to create a room where all members can even join from different networks.

I've already tested it and so I can say it is possible and would work nicely (See screenshot).

Do you have any concerns or do you agree?

Screenshot 2019-08-15 at 12 49 22

@morgankevinj
Copy link

There is another open source app that has this feature:
https://github.com/cowbell/sharedrop

@NoverNobida
Copy link

It's great. How did you achieve it? I don't know much about node.js.

@opusonline
Copy link
Author

@nover2 Have a look at https://github.com/RobinLinus/snapdrop/blob/894824eb19708c5950c9076b2c4f50b489b2d4f0/server/index.js#L60. There you'll see that Snapdrop groups users (peers) by their IP address. This is great to start. To achieve rooms across different networks you need to update the app and let the frontend/backend create valid unique room id's that are added to the URL so that the URL can be shared and users using the same URL are sharing the same room no matter in which network they are.

@NoverNobida
Copy link

@opusonline
Maybe it is difficult for me. The app is lastest version, but I can't understand how to create valid unique room id in frontend and backend. Maybe I need detailed docs.

@opusonline
Copy link
Author

@nover2
Sorry, now I see your problem. Unfortunately you have to be able to code updates and implement the feature on your own. It is currently not built in (this is the reason why this thread exists).

@NoverNobida
Copy link

@opusonline
Take the liberty to ask if it is possible to show the code that implements this feature? Is it just a matter of making changes to index.html? I think this is an opportunity for me to learn.

@opusonline
Copy link
Author

@nover2
Sorry, this is not just a matter of making changes to index.html. You would have to adjust the server side and add new elements on the frontend. You really already need profound programming skills to achieve this.

@lrq3000
Copy link

lrq3000 commented May 25, 2020

@opusonline maybe you can make a PR out of your changes? This may help the developers merge in this feature faster.

@RobinLinus
Copy link
Collaborator

Duplicate of #144

@RobinLinus RobinLinus marked this as a duplicate of #144 Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants