Allow move-only types in Promise<>. (based on contribution from jb-gcx)

Snapchat · Jul 15, 2024 · f603002 · f603002
1 parent cc8190a
commit f603002
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/support-lib/cpp/Future.hpp b/support-lib/cpp/Future.hpp
@@ -57,6 +57,7 @@ struct ValueHolder {
     using type = T;
     std::optional<T> value;
     T getValueUnsafe() const {return *value;}
+    T getValueUnsafe() {return std::move(*value);}
 };
 template <>
 struct ValueHolder<void> {

diff --git a/test-suite/handwritten-src/cpp/test_helpers.cpp b/test-suite/handwritten-src/cpp/test_helpers.cpp
@@ -19,6 +19,11 @@
 
 namespace testsuite {
 
+// verify we we can put move only types in futures
+std::unique_ptr<int> testFutureMove() {
+    return djinni::Promise<std::unique_ptr<int>>::resolve(nullptr).get();
+}
+
 SetRecord TestHelpers::get_set_record() {
     return SetRecord { {
         "StringA",