Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 job to the github actions #107

Open
micah-prime opened this issue Aug 22, 2024 · 2 comments
Open

Add flake8 job to the github actions #107

micah-prime opened this issue Aug 22, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request maintenance Code and repository related maintenance

Comments

@micah-prime
Copy link
Contributor

No description provided.

@micah-prime micah-prime added the enhancement New feature or request label Aug 22, 2024
@micah-prime micah-prime self-assigned this Aug 22, 2024
@jomey
Copy link
Member

jomey commented Aug 22, 2024

Just talked to Weji and he recommended Ruff
https://docs.astral.sh/ruff/

@lsetiawan
Copy link
Collaborator

Instead of simply running style checks within github actions, it is now recommended to have a pre-commit instead that runs before any code changes is committed. Once pre-commit is setup, you can setup pre-commit.ci integration so that PR from outside contributors also get a style check. As @jomey referenced above, ruff will work with pre-commit.. simply add a hook to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance Code and repository related maintenance
Projects
None yet
Development

No branches or pull requests

3 participants