From e9c0305cc292831999fbc0199d520984850bdc53 Mon Sep 17 00:00:00 2001 From: Alvsch <94403567+Alvsch@users.noreply.github.com> Date: Mon, 2 Dec 2024 21:53:59 +0100 Subject: [PATCH] Fix deadlock --- pumpkin/src/client/player_packet.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pumpkin/src/client/player_packet.rs b/pumpkin/src/client/player_packet.rs index 994b9bda3..376c63aa7 100644 --- a/pumpkin/src/client/player_packet.rs +++ b/pumpkin/src/client/player_packet.rs @@ -438,11 +438,11 @@ impl Player { Hand::from_i32(client_information.main_hand.into()), ChatMode::from_i32(client_information.chat_mode.into()), ) { - let config = self.config.lock().await; + let mut config = self.config.lock().await; let update = config.main_hand != main_hand || config.skin_parts != client_information.skin_parts; - *self.config.lock().await = PlayerConfig { + *config = PlayerConfig { locale: client_information.locale, // A Negative view distance would be impossible and make no sense right ?, Mojang: Lets make is signed :D view_distance: client_information.view_distance as u8, @@ -453,6 +453,7 @@ impl Player { text_filtering: client_information.text_filtering, server_listing: client_information.server_listing, }; + drop(config); if update { self.update_client_information().await; }