Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /give Command #234

Merged
merged 12 commits into from
Nov 7, 2024
Merged

Add /give Command #234

merged 12 commits into from
Nov 7, 2024

Conversation

user622628252416
Copy link
Contributor

@user622628252416 user622628252416 commented Nov 6, 2024

Description

add /give command

Testing

todo/see below

Checklist

Things need to be done before this Pull Request can be merged.

Blockers

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings cargo clippy
  • inform client about inventory updates
  • use item_registry instead of block_registry (blocked on Item extractor extracts wrong data for id field #236)

Discarded Ideas

@user622628252416

This comment was marked as resolved.

@user622628252416 user622628252416 marked this pull request as ready for review November 6, 2024 18:06
@user622628252416 user622628252416 marked this pull request as draft November 6, 2024 18:06
@user622628252416 user622628252416 marked this pull request as ready for review November 6, 2024 23:36
@Snowiiii
Copy link
Owner

Snowiiii commented Nov 7, 2024

@user622628252416 is this ready for merge ?

@user622628252416
Copy link
Contributor Author

user622628252416 commented Nov 7, 2024

@Snowiiii It is

@Snowiiii Snowiiii changed the title /give Command Add /give Command Nov 7, 2024
@Snowiiii
Copy link
Owner

Snowiiii commented Nov 7, 2024

LGTM.
Thanks @user622628252416

@Snowiiii Snowiiii merged commit 16dabf1 into Snowiiii:master Nov 7, 2024
9 checks passed
@user622628252416 user622628252416 deleted the cmd_give branch November 16, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants