chore(api): add explicit helper to force fail a test when using try c…

…atch
SocialGouv · Jan 28, 2025 · f650a16 · f650a16
1 parent 42dc8d6
commit f650a16
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/...i/modules/candidacy/certification/features/updateCertificationWithinOrganismScope.test.ts b/...i/modules/candidacy/certification/features/updateCertificationWithinOrganismScope.test.ts
@@ -18,6 +18,7 @@ import {
   getGraphQLError,
 } from "../../../../test/jestGraphqlClient";
 import { graphql } from "../../../graphql/generated";
+import { shouldNotGoHere } from "../../../../test/jestHelpers";
 
 let app: FastifyInstance;
 
@@ -261,7 +262,7 @@ test("should not be able to update certification that is not in its scope", asyn
       candidacy,
       organism,
     });
-    fail("an error should be thrown");
+    shouldNotGoHere();
   } catch (error) {
     const gqlError = getGraphQLError(error);
     expect(gqlError).toEqual(
@@ -284,7 +285,7 @@ test("should not be able to update certification after feasibility sent", async
       candidacy,
       organism,
     });
-    fail("an error should be thrown");
+    shouldNotGoHere();
   } catch (error) {
     const gqlError = getGraphQLError(error);
     expect(gqlError).toEqual(

diff --git a/packages/reva-api/test/jestHelpers.ts b/packages/reva-api/test/jestHelpers.ts
@@ -0,0 +1,5 @@
+export const shouldNotGoHere = () => {
+  throw new Error(
+    "Ce test a échoué car la requête GraphQL n'a pas levé l'erreur attendue",
+  );
+};