Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode Contributions - review after the hackathon utrecht August 1-3 #55

Open
orchid00 opened this issue Sep 7, 2018 · 1 comment
Open
Assignees
Labels
Contribution-episode Hacktoberfest https://hacktoberfest.digitalocean.com/

Comments

@orchid00
Copy link
Contributor

orchid00 commented Sep 7, 2018

@Pfern @fmichonneau @malvikasharan

Thanks for your contributions to the Contributions episode.
I just merged the PR.
#24 and addressed the smaller changes.

How to continue? Please see the comments listed below. The order is: Number, topic and what to change and who suggested it. If you rather not address any of the TODOs please share the reasoning.

General comments:
We could work on one point each as they are four. Or we could discuss here in comments each point and then proceed.
Also I suggest giving it a full review now that is merged, and add points that need to be modified. If you see any short typos, please send smaller PR's.

Reviews numbered

  1. To allow meaningful contributions,
    it is crucial to make your project FAIR

TODO:
@mkuzak: how do the meaningful contributions are connected to being FAIR?
@orchid00: also I'm not sure how to make the connection, but there might be sub points to relate.

  1. If you are not yet convinced that having your project open for contributions is

TODO:
@mkuzak: I don't know, how me not being sure about the advantages of opening the project has to do with questions on how people can contribute.

  1. For the developers to make relevant contributions, it is also worth thinking...

TODO:
@mkuzak: This is a very long and hard to understand sentence. Can you rewrite and simplify it?

  1. Technical requirements (software versions, space, etc)
    TODO:
    @mkuzak: what kind of space? hard drive space?
@orchid00 orchid00 changed the title Licence Contributions - review after the hackathon utrecht August 1-3 Episode Contributions - review after the hackathon utrecht August 1-3 Oct 1, 2018
@orchid00
Copy link
Contributor Author

orchid00 commented Oct 1, 2018

Hello team! @Pfern @fmichonneau @malvikasharan
Can we work on this on Oct 3rd? allowing for time differences.

@orchid00 orchid00 added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution-episode Hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

No branches or pull requests

2 participants