Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions - Additional Loot Bag and JER Mob Drop pages #37

Open
Luke616 opened this issue May 22, 2022 · 1 comment
Open

Suggestions - Additional Loot Bag and JER Mob Drop pages #37

Luke616 opened this issue May 22, 2022 · 1 comment

Comments

@Luke616
Copy link

Luke616 commented May 22, 2022

Hello,

Wanted to suggest a few more mods which would fit right in with the compat features of this mod. Thanks for reading and considering them, and thanks for the great mod!

Best,
Luke616


MIA Suggestions:

Chest Loot contents JER screen:

Mob Drop info JER screen:

  • Twilight Forest Adds lots of mobs, including some bosses which drop important items
  • Grimoire of Gaia Adds lots of mobs, many of which drop unique items which would be important to know how to access
  • Electroblob's Wizardry Really only adds one hostile mob by default (an Evil Wizard) but it'd be nice to know what he drops
  • Bewitchment Adds a few mobs, and some special drops from them when killed using a specific dagger. This info would be very useful to have in JEI

General suggestions:

  • Remove any mob drop screens that are empty/have no contents from JEI
  • Add support for JER display of mob drops specified with crafttweaker's IEntityDefinition
    • Example: this line will cause sheep to drop 4-6 ingots at an 80% chance, but is not reflected in JER
      <entity:minecraft:sheep>.addDrop(<minecraft:iron_ingot> % 80, 4, 6);
@SokyranTheDragon
Copy link
Owner

Sorry for rather late response, been working on other stuff. I generally want to slowly move away from 1.12 and update to more recent versions, but I may look into adding a couple more mods in.

From those that you've listed I've only played with Twilight Forest, so it'd be the easiest for me to add support for it. The others, I'd have to look deeper into them to learn more about them.

Remove any mob drop screens that are empty/have no contents from JEI
This should be rather easy to do, I hope. I'll look into it. I'll make that an option though, as I feel in some cases it may be useful to have (checking which mobs are enabled in the game).

Add support for JER display of mob drops specified with crafttweaker's IEntityDefinition
Hmm... Complexity of it may depend on how it's done. And the more problematic factor: if those drops are added after JER registers the mob drops with JEI, it'll make it significantly harder to do. Still, I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants