You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
get rid of nbTrackables and use parser library (nlohmann) API to iterate over elements. If an order is needed, use a JSON array.
don't use url field to store a human readable Fiducial marker name. Instead, with the previous suggestion, the naming convention of elements is no longer required, and marker elements can be given names. url could be use optionnally to point to a image representing the marker, so that a user have a preview of it (easier to see than mentally parsing the pattern) and print it to test the pipeline.
use human readable names for marker types (ex: "FIDUCIAL", "IMAGE", QRCODE", ...)
Nice to have: a JSON schema to validate the files. This would prevent user from adding a code field to a fiducial marker description for example.
With this modification, the previous file could go from looking like this:
PROBLEM
Currently marker descriptor usage looks like this:
https://github.com/SolarFramework/Sample-Relocalization/blob/master/SolARPipeline_RelocalizationMarker/tests/SolARPipelineTest_RelocalizationMarker/markers.json
nbTrackables
that needs to be in sync with the file contenttrackable 1
The parser is here:
https://github.com/SolarFramework/SolARModuleTools/blob/develop/src/SolARWorldGraphLoader.cpp
SUGGESTION
nbTrackables
and use parser library (nlohmann) API to iterate over elements. If an order is needed, use a JSON array.url
field to store a human readable Fiducial marker name. Instead, with the previous suggestion, the naming convention of elements is no longer required, and marker elements can be given names.url
could be use optionnally to point to a image representing the marker, so that a user have a preview of it (easier to see than mentally parsing thepattern
) and print it to test the pipeline.code
field to a fiducial marker description for example.With this modification, the previous file could go from looking like this:
to this:
The text was updated successfully, but these errors were encountered: