Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Leak #18

Open
Ryan-Red opened this issue Jun 27, 2022 · 0 comments
Open

Memory Leak #18

Ryan-Red opened this issue Jun 27, 2022 · 0 comments
Labels
bug Something isn't working detective work More research required good first issue Good for newcomers

Comments

@Ryan-Red
Copy link
Collaborator

Memory Leak due to MapPoins and KeyFrames not being deleted, only the pointers.

UZ-SLAMLab/ORB_SLAM3#219
@Ryan-Red Ryan-Red added bug Something isn't working detective work More research required labels Jun 27, 2022
@Soldann Soldann added the good first issue Good for newcomers label Jul 5, 2022
@DavidPetkovsek DavidPetkovsek mentioned this issue Jul 14, 2022
Open
Veng97 pushed a commit to Veng97/MORB_SLAM that referenced this issue Aug 28, 2023
@DavidPetkovsek @nicolejinn @justinmetivier
Clean slam (Soldann#16)
67cf5a2 
* New java style enums

* Compile with new java style enums

* change some locks

* Clean more and add comments

* Clean mostly iterators

* Make refactor readability changes

Co-authored-by: Nicole Jin <[email protected]>
Co-authored-by: justinmetivier <[email protected]>

* Fix compile issues

* clean up some of the iterators and formatting

* Remove unused functions and member fields

* Remove unused variables or take out more member variables

* Resolve nan issue

* fixes Soldann#14

* Merge 9 minimum cmake version (Soldann#18)

* Update cmake to be compatible with latest minor version from apt

* Add dependency installer

* Update readme to show install and build instructions

* Reverted some breaking slam 'refactoring' (Soldann#19)

SLAM would not continue to 'spam print' and would frequently have invalid_argument exceptions thrown or other segmentation faults. This was due to some changes that were accidentally made to for loops in an invalid way.

We reverted more than might have been required but not much.

---------------

Co-authored-by: Nicole Jin <[email protected]>

* Potentially fix segfault from PredictStateIMU

* fixes Soldann#22

* Add quality of life changes for cmake, build, and clean

* Handle compile warnings and issues when compiling with clang17 and c++20

* Address g2o clang compile typeid warnings

* Call PoseOptimization if there are no imu frames in track local map

---------

Co-authored-by: Nicole Jin <[email protected]>
Co-authored-by: justinmetivier <[email protected]>
Co-authored-by: Nicole Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working detective work More research required good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ryan-Red @Soldann