From a19e643cdbce8ba82a5422696d83ee85a24f51d4 Mon Sep 17 00:00:00 2001
From: Solomon Jacobs <solomon.jacobs@checkmk.com>
Date: Fri, 8 Mar 2024 07:47:23 +0100
Subject: [PATCH] simplify release

workflow

test release
---
 .github/workflows/rcc.yaml           | 5 +++--
 .github/workflows/release.yaml       | 6 ++++--
 .github/workflows/robotmk_build.yaml | 8 ++++----
 .github/workflows/system_tests.yaml  | 5 +++--
 4 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/rcc.yaml b/.github/workflows/rcc.yaml
index b82fd2ee..c1b9b4fe 100644
--- a/.github/workflows/rcc.yaml
+++ b/.github/workflows/rcc.yaml
@@ -60,7 +60,8 @@ jobs:
           path: build
           key: rcc-${{ env.RCC_TAG }}-${{ env.GO_VERSION }}-${{ env.RUBY_VERSION }}
           fail-on-cache-miss: true
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
-          path: build
+          name: rcc
+          path: build/
           if-no-files-found: error
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
index fe57423a..5481df03 100644
--- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -28,9 +28,11 @@ jobs:
         # release. For setting a different ref, all `needs` jobs need to be
         # adjusted. Currently, everything uses the default branch.
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
+        with:
+          path: executables/
 
-      - run: zip -r executables.zip artifact
+      - run: zip -r executables.zip executables
 
       - name: "Push release tag"
         # This is publicly visible and needs to be manually fixed if any
diff --git a/.github/workflows/robotmk_build.yaml b/.github/workflows/robotmk_build.yaml
index 81fd2247..b2e8edd2 100644
--- a/.github/workflows/robotmk_build.yaml
+++ b/.github/workflows/robotmk_build.yaml
@@ -17,9 +17,9 @@ jobs:
 
       - run: cargo build --target=x86_64-pc-windows-gnu --release
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
-          path: |
-            ${{ github.workspace }}/target/x86_64-pc-windows-gnu/release/robotmk_scheduler.exe
-            ${{ github.workspace }}/target/x86_64-pc-windows-gnu/release/robotmk_agent_plugin.exe
+          name: rmk_windows64
+          path: ${{ github.workspace }}/target/x86_64-pc-windows-gnu/release/
           if-no-files-found: error
+
diff --git a/.github/workflows/system_tests.yaml b/.github/workflows/system_tests.yaml
index d9ebc55e..172ac89a 100644
--- a/.github/workflows/system_tests.yaml
+++ b/.github/workflows/system_tests.yaml
@@ -13,7 +13,7 @@ jobs:
     needs:
       - rcc
     steps:
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           path: C:\
       - uses: actions/checkout@v4
@@ -25,6 +25,7 @@ jobs:
           TEST_DIR: C:\test_scheduler
           RCC_BINARY_PATH: C:\artifact\windows64\rcc.exe
           RUN_FOR: 240
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           path: C:\test_scheduler
+          overwrite: true