fix fee bump transaction and add test

Author: christian-rogobete

CHANGELOG.md

@@ -1,3 +1,8 @@
+## [0.8.3] - 01.Jul.2020.
+- Add fee stats implementation
+- Add max operation fee
+- Fix fee bump transaction
+
 ## [0.8.2] - 28.Jun.2020.
 - Add query tests for accounts, efffects, ledgers.
 - Fix ledger response parsing.

README.md

@@ -1,22 +1,23 @@
 # [Stellar SDK for Flutter](https://github.com/Soneso/stellar_flutter_sdk)
 
-![Beta Version](https://img.shields.io/badge/Beta-v0.8.2-yellow.svg)
+![Beta Version](https://img.shields.io/badge/Beta-v0.8.3-yellow.svg)
 ![Dart](https://img.shields.io/badge/Dart-green.svg)
 ![Flutter](https://img.shields.io/badge/Flutter-blue.svg)
 ![Supports Stellar Horizon v1.4.0](https://img.shields.io/badge/Horizon-v1.4.0-blue.svg)
+![Supports Stellar Horizon v1.5.0](https://img.shields.io/badge/Horizon-v1.5.0-blue.svg)
 ![Supports Stellar Core v13](https://img.shields.io/badge/Core-v13-blue.svg)
 
 The Soneso open source Stellar SDK for Flutter is build with Dart and provides APIs to build and sign transactions, connect and query [Horizon](https://github.com/stellar/horizon).
 
-The SDK is currently in beta stage - v. 0.8.2. 
+The SDK is currently in beta stage - v. 0.8.3. 
 
 ## Installation
 
 ### From pub.dev
 1. Add the dependency to your pubspec.yaml file:
 ```
 dependencies:
-  stellar_flutter_sdk: ^0.8.2
+  stellar_flutter_sdk: ^0.8.3
 ```
 2. Install it (command line or IDE):
 ```

lib/src/stellar_sdk.dart

@@ -27,7 +27,7 @@ import 'requests/trades_request_builder.dart';
 
 /// Main class of the flutter stellar sdk.
 class StellarSDK {
-  static const versionNumber = "0.8.2";
+  static const versionNumber = "0.8.3";
 
   static final StellarSDK PUBLIC =
       new StellarSDK("https://horizon.stellar.org");
@@ -126,12 +126,25 @@ class StellarSDK {
   /// Submits a [transaction] to the network.
   Future<SubmitTransactionResponse> submitTransaction(
       Transaction transaction) async {
+    return submitTransactionEnvelopeXdrBase64(
+        transaction.toEnvelopeXdrBase64());
+  }
+
+  /// Submits a [feeBumpTransaction] to the network.
+  Future<SubmitTransactionResponse> submitFeeBumpTransaction(
+      FeeBumpTransaction feeBumpTransaction) async {
+    return submitTransactionEnvelopeXdrBase64(
+        feeBumpTransaction.toEnvelopeXdrBase64());
+  }
+
+  Future<SubmitTransactionResponse> submitTransactionEnvelopeXdrBase64(
+      String transactionEnvelopeXdrBase64) async {
     Uri callURI = _serverURI.replace(pathSegments: ["transactions"]);
 
     //print("Envelope XDR: " + transaction.toEnvelopeXdrBase64());
     SubmitTransactionResponse result = await _httpClient
         .post(callURI,
-            body: {"tx": transaction.toEnvelopeXdrBase64()},
+            body: {"tx": transactionEnvelopeXdrBase64},
             headers: RequestBuilder.headers)
         .then((response) {
       SubmitTransactionResponse submitTransactionResponse;

lib/src/transaction.dart

@@ -372,7 +372,8 @@ class TransactionBuilder {
   TransactionBuilder setMaxOperationFee(int maxOperationFee) {
     checkNotNull(maxOperationFee, "maxOperationFee cannot be null");
     if (maxOperationFee < AbstractTransaction.MIN_BASE_FEE) {
-      throw new Exception("maxOperationFee cannot be smaller than the BASE_FEE (${AbstractTransaction.MIN_BASE_FEE}): ${maxOperationFee}");
+      throw new Exception(
+          "maxOperationFee cannot be smaller than the BASE_FEE (${AbstractTransaction.MIN_BASE_FEE}): $maxOperationFee");
     }
     _mMaxOperationFee = maxOperationFee;
     return this;
@@ -413,6 +414,7 @@ class FeeBumpTransaction extends AbstractTransaction {
       : super(innerTransaction.network) {
     _mFeeAccount = checkNotNull(feeAccount, "feeAccount cannot be null");
     _mFee = checkNotNull(fee, "fee cannot be null");
+    _mInner = innerTransaction;
   }
 
   static FeeBumpTransaction fromFeeBumpTransactionEnvelope(

lib/src/xdr/xdr_transaction.dart

@@ -158,7 +158,7 @@ class XdrFeeBumpTransactionInnerTx {
   static void encode(XdrDataOutputStream stream,
       XdrFeeBumpTransactionInnerTx encodedTransaction) {
     stream.writeInt(encodedTransaction.discriminant.value);
-    switch (encodedTransaction.discriminant.value) {
+    switch (encodedTransaction.discriminant) {
       case XdrEnvelopeType.ENVELOPE_TYPE_TX:
         XdrTransactionV1Envelope.encode(stream, encodedTransaction.v1);
         break;
@@ -168,7 +168,7 @@ class XdrFeeBumpTransactionInnerTx {
   static XdrFeeBumpTransactionInnerTx decode(XdrDataInputStream stream) {
     XdrFeeBumpTransactionInnerTx decoded = XdrFeeBumpTransactionInnerTx();
     decoded.discriminant = XdrEnvelopeType.decode(stream);
-    switch (decoded.discriminant.value) {
+    switch (decoded.discriminant) {
       case XdrEnvelopeType.ENVELOPE_TYPE_TX:
         decoded.v1 = XdrTransactionV1Envelope.decode(stream);
         break;

pubspec.yaml

@@ -1,6 +1,6 @@
 name: stellar_flutter_sdk
 description: A stellar blockchain sdk that query's horizon, build, signs and submits transactions to the stellar netweok.
-version: 0.8.2
+version: 0.8.3
 homepage: https://github.com/Soneso/stellar_flutter_sdk
 
 environment:

test/fee_bump_transaction_test.dart

@@ -0,0 +1,59 @@
+@Timeout(const Duration(seconds: 300))
+
+import 'package:flutter_test/flutter_test.dart';
+import 'package:stellar_flutter_sdk/stellar_flutter_sdk.dart';
+
+void main() {
+  StellarSDK sdk = StellarSDK.TESTNET;
+
+  test('submit fee bump transaction', () async {
+    KeyPair sourceKeyPair = KeyPair.random();
+    String sourceId = sourceKeyPair.accountId;
+    KeyPair destinationKeyPair = KeyPair.random();
+    String destinationId = destinationKeyPair.accountId;
+    KeyPair payerKeyPair = KeyPair.random();
+    String payerId = payerKeyPair.accountId;
+
+    await FriendBot.fundTestAccount(sourceId);
+    await FriendBot.fundTestAccount(payerId);
+
+    AccountResponse sourceAccount = await sdk.accounts.account(sourceId);
+
+    // fund account C.
+    Transaction innerTx = new TransactionBuilder(sourceAccount, Network.TESTNET)
+        .addOperation(
+            new CreateAccountOperationBuilder(destinationId, "10").build())
+        .build();
+
+    innerTx.sign(sourceKeyPair);
+
+    FeeBumpTransaction feeBump = new FeeBumpTransactionBuilder(innerTx)
+        .setBaseFee(200)
+        .setFeeAccount(payerId)
+        .build();
+    feeBump.sign(payerKeyPair);
+
+    SubmitTransactionResponse response =
+        await sdk.submitFeeBumpTransaction(feeBump);
+    assert(response.success);
+
+    AccountResponse destination = await sdk.accounts.account(destinationId);
+    for (Balance balance in destination.balances) {
+      if (balance.assetType == Asset.TYPE_NATIVE) {
+        assert(double.parse(balance.balance) > 9);
+        break;
+      }
+    }
+
+    TransactionResponse transaction =
+        await sdk.transactions.transaction(response.hash);
+    assert(transaction.feeBumpTransaction != null);
+    assert(transaction.feeBumpTransaction.signatures.length > 0);
+    assert(transaction.innerTransaction.hash != null);
+    assert(transaction.innerTransaction.maxFee == 100);
+
+    transaction =
+        await sdk.transactions.transaction(transaction.innerTransaction.hash);
+    assert(transaction.sourceAccount == sourceId);
+  });
+}

test/query_test.dart

@@ -182,19 +182,16 @@ void main() {
   });
 
   test('test query ledgers', () async {
-
     Page<LedgerResponse> ledgersPage =
-    await sdk.ledgers.limit(1).order(RequestBuilderOrder.DESC).execute();
+        await sdk.ledgers.limit(1).order(RequestBuilderOrder.DESC).execute();
     assert(ledgersPage.records.length == 1);
     LedgerResponse ledger = ledgersPage.records.first;
 
     LedgerResponse ledger2 = await sdk.ledgers.ledger(ledger.sequence);
     assert(ledger.sequence == ledger2.sequence);
-
   });
 
   test('test query fee stats', () async {
-
     FeeStatsResponse feeStats = await sdk.feeStats.execute();
     assert(feeStats.lastLedger.isNotEmpty);
     assert(feeStats.lastLedgerBaseFee.isNotEmpty);