We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think I found an issue with one condition here:
react-sortablejs/src/react-sortable.tsx
Line 121 in 48e8780
My render looks like this (psudo)
interface Data { columns: string[]; optionalColumns?: string[]; } [..] return ( <ReactSortable ...> {optionalColumns?.map(x => <Item x={x} />)} {columns.map(x => <Item x={x} />)} </ReactSortable> )
It fails for me on line:
Line 124 in 48e8780
Because the guard at line 121 does not handle this...
null === undefined // false
Shouldn't there be just child == null ? Double eq with null, which will handle nulls and undefineds?
child == null
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I think I found an issue with one condition here:
react-sortablejs/src/react-sortable.tsx
Line 121 in 48e8780
My render looks like this (psudo)
It fails for me on line:
react-sortablejs/src/react-sortable.tsx
Line 124 in 48e8780
Because the guard at line 121 does not handle this...
null === undefined // false
Shouldn't there be just
child == null
? Double eq with null, which will handle nulls and undefineds?The text was updated successfully, but these errors were encountered: