Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHOULD_NOT_SLEEP and SHOULD_BE_PURE have false positives based on incorrect inheritance assumptions #334

Open
out-of-phaze opened this issue Aug 23, 2022 · 1 comment
Open

SHOULD_NOT_SLEEP and SHOULD_BE_PURE have false positives based on incorrect inheritance assumptions #334

out-of-phaze opened this issue Aug 23, 2022 · 1 comment
Labels
bug dreamchecker

Comments

@out-of-phaze
Copy link
Contributor 

/proc/foo()
    SHOULD_NOT_SLEEP(TRUE)

/datum/proc/foo()
    sleep(5)

/datum/proc/foo() will report that it has SHOULD_NOT_SLEEP set when it shouldn't.
@out-of-phaze
Copy link
Contributor Author

image
An example in a real environment, although the proc didn't originally have the annotation--it was added for demonstration.

@out-of-phaze out-of-phaze mentioned this issue Aug 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug dreamchecker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SpaceManiac @out-of-phaze