Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log improvement #37

Open
segaura opened this issue Feb 11, 2021 · 0 comments · Fixed by #38
Open

log improvement #37

segaura opened this issue Feb 11, 2021 · 0 comments · Fixed by #38

Comments

@segaura
Copy link

segaura commented Feb 11, 2021

Hallo.
My suggestion is to improve the logging.
Current problems are:

  • Output log level cannot be controller via options, it is hardcoded
  • "printd()" method mixes log, output message and has also dependency on it parent implementation, because of the "self.driver != "HPSUD"" check
  • Developers are discouraged to add log because of how "printd()" is implemented, the risk of writing to stdout along command output is real; current code has no log at DEBUG or INFO level probably because of this
  • Log is substantially absent
  • Implemented log levels are not the usual ones, e.g. DEBUG level is missing
  • Logging methods specify level using strings and this is prone to error and inhibits code auto-completion

I prepared a pull request solving all of this, it is really "big" because it removes printd() in favor of standard logging methods and this involves almost all of the python files.
I will submit the pull request so we can discuss on the technical decisions, if you are interested on.

@segaura segaura mentioned this issue Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant