added type coercion for booleans #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, this is an ridiculously late response but I want to thank you for putting together this very reasonable PR. We completely dropped the ball on maintaining this library; we're sorry for that and understand how annoying it is to get radio silence after putting work into a PR. We're currently undergoing a review of our open source policies w/ legal and, for what it's worth, should be able to move forward on this and the other open PRs soon. |
|
Great!!
…On Thu, Jun 21, 2018, 02:35 Nathan Sorenson ***@***.***> wrote:
Hey, this is an ridiculously late response but I want to thank you for
putting together this very reasonable PR. We completely dropped the ball on
maintaining this library; we're sorry for that and understand how annoying
it is to get radio silence after putting work into a PR. We're currently
undergoing a review of our open source policies w/ legal and, for what it's
worth, should be able to move forward on this and the other open PRs soon.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB0kP6Nly4oB4uTkUmUy0x70M-TZEnwaks5t-qQKgaJpZM4OTsHA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you accept this one I'll do some more pull requests for you regarding formatting etc.